Attachment 112848 Details for Bug 26819 – Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt

[patch] Bug 26819: Fix calls to AuthorisedValues.GetDescriptionByKohaField in course-details.tt

Bug-26819-Fix-calls-to-AuthorisedValuesGetDescript.patch (text/plain), 3.22 KB, created by Kyle M Hall (khall) on 2020-11-02 15:36:40 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-11-02 15:36:40 UTC

Size: 3.22 KB

patch

obsolete

>From c7e67a8024dbfcf5e6b394c01c64e73e91035d35 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Mon, 2 Nov 2020 10:34:35 -0500
>Subject: [PATCH] Bug 26819: Fix calls to
> AuthorisedValues.GetDescriptionByKohaField in course-details.tt
>
>Test Plan:
>1) In the staff interface go to course reserves.
>2) Add a new course.
>3) Add a reserve (Add reserves > add a valid barcode > submit).
>4) Go to the list of courses and select the course you added the item to.
>5) An error trace log is generated
>6) Apply this patch
>7) Reload the page
>8) No errors!
>---
> .../prog/en/modules/course_reserves/course-details.tt | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>index 32b33b6ba4..d6c66c6e64 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/course_reserves/course-details.tt
>@@ -127,18 +127,18 @@
> [% IF cr.course_item.enabled == 'yes' %]
> [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorized_value => cr.item.ccode ) | html %]
> [% IF cr.item.ccode %]
>- ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', cr.course_item.ccode_storage ) | html %])
>+ ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorized_value => cr.course_item.ccode_storage ) | html %])
> [% END %]
> [% ELSE %]
>- [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', cr.course_item.ccode ) | html %]
>+ [% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorized_value => cr.course_item.ccode ) | html %]
> [% IF cr.item.ccode %]
>- ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', cr.item.ccode ) | html %])
>+ ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorized_value => cr.item.ccode ) | html %])
> [% END %]
> [% END %]
> [% ELSE %]
> Unchanged
> [% IF cr.item.ccode %]
>- ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', cr.item.ccode ) | html %])
>+ ([% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorized_value => cr.item.ccode ) | html %])
> [% END %]
> [% END %]
> </td>
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26819: 112487 | 112848 | 112861 | 112878 | 113926 | 113927 | 113978 | 113979 | 113980