Attachment 112867 Details for Bug 26892 – Bug 26892: Remove warnings from Koha/Patrons.t

[patch] Bug 26892: Remove warnings from Koha/Patrons.t

Bug-26892-Remove-warnings-from-KohaPatronst.patch (text/plain), 2.99 KB, created by David Nind on 2020-11-02 19:37:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-11-02 19:37:55 UTC

Size: 2.99 KB

patch

obsolete

>From c7b10d0b8cfce5135fdeabdbdd2fbdb46da82d29 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 2 Nov 2020 11:26:44 +0100
>Subject: [PATCH] Bug 26892: Remove warnings from Koha/Patrons.t
>
>Test plan:
>Confirm that the warnings "item-level_itypes set but no itemtype set for item"
>disappear after applying this patch
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> t/db_dependent/Koha/Patrons.t | 12 +++++-------
> 1 file changed, 5 insertions(+), 7 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 60c9a7324c..aa04e0564c 100755
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -566,7 +566,7 @@ subtest 'checkouts + pending_checkouts + get_overdues + old_checkouts' => sub {
>     plan tests => 17;
> 
>     my $library = $builder->build( { source => 'Branch' } );
>-    my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
>+    my $biblionumber_1 = $builder->build_sample_biblio->biblionumber;
>     my $item_1 = $builder->build_sample_item(
>         {
>             library      => $library->{branchcode},
>@@ -579,7 +579,7 @@ subtest 'checkouts + pending_checkouts + get_overdues + old_checkouts' => sub {
>             biblionumber => $biblionumber_1,
>         }
>     );
>-    my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
>+    my $biblionumber_2 = $builder->build_sample_biblio->biblionumber;
>     my $item_3 = $builder->build_sample_item(
>         {
>             library      => $library->{branchcode},
>@@ -937,7 +937,7 @@ subtest 'holds and old_holds' => sub {
>     plan tests => 6;
> 
>     my $library = $builder->build( { source => 'Branch' } );
>-    my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
>+    my $biblionumber_1 = $builder->build_sample_biblio->biblionumber;
>     my $item_1 = $builder->build_sample_item(
>         {
>             library      => $library->{branchcode},
>@@ -950,7 +950,7 @@ subtest 'holds and old_holds' => sub {
>             biblionumber => $biblionumber_1,
>         }
>     );
>-    my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
>+    my $biblionumber_2 = $builder->build_sample_biblio->biblionumber;
>     my $item_3 = $builder->build_sample_item(
>         {
>             library      => $library->{branchcode},
>@@ -1394,7 +1394,7 @@ subtest 'get_overdues' => sub {
>     plan tests => 7;
> 
>     my $library = $builder->build( { source => 'Branch' } );
>-    my ($biblionumber_1) = AddBiblio( MARC::Record->new, '' );
>+    my $biblionumber_1 = $builder->build_sample_biblio->biblionumber;
>     my $item_1 = $builder->build_sample_item(
>         {
>             library      => $library->{branchcode},
>@@ -1407,11 +1407,9 @@ subtest 'get_overdues' => sub {
>             biblionumber => $biblionumber_1,
>         }
>     );
>-    my ($biblionumber_2) = AddBiblio( MARC::Record->new, '' );
>     my $item_3 = $builder->build_sample_item(
>         {
>             library      => $library->{branchcode},
>-            biblionumber => $biblionumber_2,
>         }
>     );
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26892: 112823 | 112867 | 112877