Bugzilla – Attachment 112890 Details for
Bug 26664
Inventory: Sorting column 'Last seen' goes wrong
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26664: Fix sorting for date last seen in inventory tool
Bug-26664-Fix-sorting-for-date-last-seen-in-invent.patch (text/plain), 2.34 KB, created by
Martin Renvoize (ashimema)
on 2020-11-03 08:12:40 UTC
(
hide
)
Description:
Bug 26664: Fix sorting for date last seen in inventory tool
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-11-03 08:12:40 UTC
Size:
2.34 KB
patch
obsolete
>From b2c64c3f581f894094fa363a8b5f1a45c35ec4e4 Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Mon, 5 Oct 2020 17:48:45 +0000 >Subject: [PATCH] Bug 26664: Fix sorting for date last seen in inventory tool > >This adds the standard datatable sorting for dates to the inventory >table as described here: >https://wiki.koha-community.org/wiki/DataTables_HowTo#Sorting_dates_regardless_of_date_format_preference > >To test: >- Go to the inventory tool >- Search for a big sample list of items with different date last seen >- Sort the table now by "date last seen" by clicking on the table header cell >- Try different settings of the DateFormat system preferences >- Verify sorting is incorrect (alphabetic, not by date) >- Apply patch >- Repeat testing and very all is sorting correctly now > >Signed-off-by: Chris Cormack <chrisc@catalyst.net.nz> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt >index 5346304268..8e6b66009b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/inventory.tt >@@ -200,7 +200,7 @@ > <th>Lost</th> > <th>Damaged</th> > <th>Withdrawn</th> >- <th>Last seen</th> >+ <th class="title-string">Last seen</th> > <th>Problems</th> > </tr> > </thead> >@@ -239,7 +239,7 @@ > [% result.withdrawn | html %] > </td> > <td> >- [% result.datelastseen | $KohaDates %] >+ <span title="[% result.datelastseen %]">[% result.datelastseen | $KohaDates%]</span> > </td> > <td> > [% FOREACH problem IN result.problems %] >@@ -350,6 +350,7 @@ > "aoColumnDefs": [ > { "sType": "anti-the", "aTargets" : [ "anti-the" ] }, > { "bSortable": false, "bSearchable": false, "aTargets": [ 0 ] }, >+ { "sType": "title-string", "aTargets" : [ "title-string" ] }, > ], > // 3rd column is callnumber > "aaSorting": [[ 2, "asc" ]], >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26664
:
111822
|
112482
| 112890 |
112891