Bugzilla – Attachment 112944 Details for
Bug 19133
Password recovery routes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 19133: (QA follow-up) Fix QA script issues
Bug-19133-QA-follow-up-Fix-QA-script-issues.patch (text/plain), 3.19 KB, created by
Kyle M Hall (khall)
on 2020-11-03 17:32:18 UTC
(
hide
)
Description:
Bug 19133: (QA follow-up) Fix QA script issues
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-11-03 17:32:18 UTC
Size:
3.19 KB
patch
obsolete
>From 477ebe18e48f466d47b5a280ef3ac17ab4c342d1 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Tue, 3 Nov 2020 12:26:48 -0500 >Subject: [PATCH] Bug 19133: (QA follow-up) Fix QA script issues > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > Koha/Patron/Password/Recovery.pm | 4 +++- > .../api/v1/patrons_password_recovery.t | 20 +++++++++---------- > 2 files changed, 13 insertions(+), 11 deletions(-) > mode change 100644 => 100755 t/db_dependent/api/v1/patrons_password_recovery.t > >diff --git a/Koha/Patron/Password/Recovery.pm b/Koha/Patron/Password/Recovery.pm >index a17e55134e..dd603e5046 100644 >--- a/Koha/Patron/Password/Recovery.pm >+++ b/Koha/Patron/Password/Recovery.pm >@@ -110,6 +110,7 @@ sub GetValidLinkInfo { > skip_mail: If true, will not enqueue the letter, but return it > instead. Use this flag if you want a third party > service to handle emailing instead of Koha. >+ > =cut > > sub SendPasswordRecoveryEmail { >@@ -159,7 +160,8 @@ sub SendPasswordRecoveryEmail { > my $allowed_list = C4::Context->preference( > 'OpacResetPasswordAllowedHosts' > ); >- my @allowed_hosts = split /[,\s\|]/, $allowed_list if defined $allowed_list; >+ my @allowed_hosts; >+ @allowed_hosts = split /[,\s\|]/, $allowed_list if defined $allowed_list; > foreach my $allowed_host (@allowed_hosts) { > if ($url =~ /^https?:\/\/$allowed_host/) { > $url =~ s/{uuid}/$uuid_str/gi; >diff --git a/t/db_dependent/api/v1/patrons_password_recovery.t b/t/db_dependent/api/v1/patrons_password_recovery.t >old mode 100644 >new mode 100755 >index 0716c2ebbf..70b0a25c6f >--- a/t/db_dependent/api/v1/patrons_password_recovery.t >+++ b/t/db_dependent/api/v1/patrons_password_recovery.t >@@ -2,18 +2,18 @@ > > # This file is part of Koha. > # >-# Koha is free software; you can redistribute it and/or modify it under the >-# terms of the GNU General Public License as published by the Free Software >-# Foundation; either version 3 of the License, or (at your option) any later >-# version. >+# Koha is free software; you can redistribute it and/or modify it >+# under the terms of the GNU General Public License as published by >+# the Free Software Foundation; either version 3 of the License, or >+# (at your option) any later version. > # >-# Koha is distributed in the hope that it will be useful, but WITHOUT ANY >-# WARRANTY; without even the implied warranty of MERCHANTABILITY or FITNESS FOR >-# A PARTICULAR PURPOSE. See the GNU General Public License for more details. >+# Koha is distributed in the hope that it will be useful, but >+# WITHOUT ANY WARRANTY; without even the implied warranty of >+# MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the >+# GNU General Public License for more details. > # >-# You should have received a copy of the GNU General Public License along >-# with Koha; if not, write to the Free Software Foundation, Inc., >-# 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA. >+# You should have received a copy of the GNU General Public License >+# along with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; > >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 19133
:
66415
|
66416
|
66419
|
94551
|
94553
|
94554
|
112751
|
112752
|
112753
|
112755
|
112756
|
112757
|
112758
|
112937
|
112938
|
112939
|
112940
|
112941
|
112942
|
112943
| 112944 |
113328