Bugzilla – Attachment 112974 Details for
Bug 26915
Koha explodes when writing off a fee with FinePaymentAutoPopup
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26915: Fix FinePaymentAutoPopup behaviour
Bug-26915-Fix-FinePaymentAutoPopup-behaviour.patch (text/plain), 1.33 KB, created by
Jonathan Druart
on 2020-11-04 08:06:38 UTC
(
hide
)
Description:
Bug 26915: Fix FinePaymentAutoPopup behaviour
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-11-04 08:06:38 UTC
Size:
1.33 KB
patch
obsolete
>From a0a7b4b17c02dd16fd6b4f0507435d5067b37342 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 4 Nov 2020 09:04:19 +0100 >Subject: [PATCH] Bug 26915: Fix FinePaymentAutoPopup behaviour > >The behaviour of the syspref FinePaymentAutoPopup is broken, the popup >explodes with > Can't call method "unblessed" on an undefined value at /home/vagrant/kohaclone/members/printfeercpt.pl line 64 > >It has been broken by > commit a2449a81be55aa5b3710ca2c6df7884513f89540 > Bug 23051: (follow-up) Add renewal feedback and move code to subroutines and test >which modified the return value of Koha::Account->pay (from $payment_id >to a hashref) > >Test plan: >- To test activate FinePaymentAutoPopup >- Create a manual fee >- Write it off using the write off button on the account line (not below table) >=> Without the patch you get the error >=> With the patch applied the popup is correctly displayed >--- > members/pay.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/pay.pl b/members/pay.pl >index eb16f04574..2fb35315da 100755 >--- a/members/pay.pl >+++ b/members/pay.pl >@@ -122,7 +122,7 @@ elsif ( $input->param('confirm_writeoff') ) { > interface => C4::Context->interface, > library_id => $branch, > } >- ); >+ )->{payment_id}; > } > } > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26915
:
112974
|
112978
|
113095