Bugzilla – Attachment 113012 Details for
Bug 26847
Make borrower category code accessible in all pages of the OPAC
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26847: Add unit test for categorycode in masthead
Bug-26847-Add-unit-test-for-categorycode-in-masthe.patch (text/plain), 1.64 KB, created by
Lucas Gass (lukeg)
on 2020-11-04 16:33:40 UTC
(
hide
)
Description:
Bug 26847: Add unit test for categorycode in masthead
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2020-11-04 16:33:40 UTC
Size:
1.64 KB
patch
obsolete
>From ee1b600d3625820e2bc9e5f39c864e66b12b5e12 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Wed, 4 Nov 2020 14:45:27 +0000 >Subject: [PATCH] Bug 26847: Add unit test for categorycode in masthead > >This unit test adds a regression test for the addition of categorycode >into the masthead of the staff client. > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > t/db_dependent/selenium/regressions.t | 7 +++++-- > 1 file changed, 5 insertions(+), 2 deletions(-) > >diff --git a/t/db_dependent/selenium/regressions.t b/t/db_dependent/selenium/regressions.t >index 3ee8fa190c..a4296901a3 100755 >--- a/t/db_dependent/selenium/regressions.t >+++ b/t/db_dependent/selenium/regressions.t >@@ -49,8 +49,8 @@ my $AudioAlerts_value = C4::Context->preference('AudioAlerts'); > C4::Context->set_preference('AudioAlerts', '1'); > > our @cleanup; >-subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub { >- plan tests => 2; >+subtest 'OPAC - borrowernumber, branchcode and categorycode as html attributes' => sub { >+ plan tests => 3; > > my $patron = $builder->build_object( > { class => 'Koha::Patrons', value => { flags => 1 } } ); >@@ -65,6 +65,9 @@ subtest 'OPAC - borrowernumber and branchcode as html attributes' => sub { > is( $elt->get_attribute('data-borrowernumber'), $patron->borrowernumber, > "Since bug 20921 span.loggedinusername should contain data-borrowernumber" > ); >+ is( $elt->get_attribute('data-categorycode'), $patron->categorycode, >+"Since bug 26847 span.loggedinusername should contain data-categorycode" >+ ); > push @cleanup, $patron, $patron->category, $patron->library; > }; > >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26847
:
113003
|
113004
|
113012
|
113013
|
114726
|
114727
|
114872