Attachment 113056 Details for Bug 26364 – Bug 26364: Remove useless condition

[patch] Bug 26364: Remove useless condition

Bug-26364-Remove-useless-condition.patch (text/plain), 974 bytes, created by David Nind on 2020-11-05 09:50:11 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-11-05 09:50:11 UTC

Size: 974 bytes

patch

obsolete

>From 6aa390adc38609486a1e2c2649da3a95b60d3035 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Wed, 9 Sep 2020 13:40:37 +0000
>Subject: [PATCH] Bug 26364: Remove useless condition
>
>$response_data is a hash with one key, content
>
>Why are we checkiing it against a string?
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> C4/XISBN.pm | 1 -
> 1 file changed, 1 deletion(-)
>
>diff --git a/C4/XISBN.pm b/C4/XISBN.pm
>index 6f7c3bf4bc..68b7c0f8d1 100644
>--- a/C4/XISBN.pm
>+++ b/C4/XISBN.pm
>@@ -102,7 +102,6 @@ sub get_xisbns {
>     # loop through each ISBN and scope to the local collection
>     for my $response_data( @{ $response->{ isbn } } ) {
>         next if $response_data->{'content'} eq $isbn;
>-        next if $isbn eq $response_data;
>         next if $unique_xisbns->{ $response_data->{content} };
>         $unique_xisbns->{ $response_data->{content} }++;
>         my $xbiblio= _get_biblio_from_xisbn($response_data->{content});
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26364: 109599 | 109631 | 109821 | 109822 | 109823 | 109824 | 109825 | 113054 | 113055 | 113056 | 113057 | 113058 | 114818 | 114819 | 114820 | 114821 | 114822