Bugzilla – Attachment 113109 Details for
Bug 24412
Attach waiting hold to desk
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24412: (follow-up) prevent request.pl from failing
Bug-24412-follow-up-prevent-requestpl-from-failing.patch (text/plain), 1.51 KB, created by
Nicolas Legrand
on 2020-11-05 13:19:07 UTC
(
hide
)
Description:
Bug 24412: (follow-up) prevent request.pl from failing
Filename:
MIME Type:
Creator:
Nicolas Legrand
Created:
2020-11-05 13:19:07 UTC
Size:
1.51 KB
patch
obsolete
>From e97260130474e9ba947b34bc5da132d72f834d59 Mon Sep 17 00:00:00 2001 >From: Nicolas Legrand <nicolas.legrand@bulac.fr> >Date: Thu, 5 Nov 2020 14:10:09 +0100 >Subject: [PATCH] Bug 24412: (follow-up) prevent request.pl from failing >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >When no desk is defined request.pl returns an internal server >error. Check a desk is defined before asking for reservation deskname. > >Plan test: > >1. log in with a library with no desk >2. check in a reserved book so it'll be switch to Ć¢waiting reserveĆ¢ >3. go to the book notice and click the Holds tab (request.pl page) >4. boum >5. apply patch, restart plack >6. refresh page >7. now loading properly >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index f631556..4df90a7 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -658,7 +658,7 @@ foreach my $biblionumber (@biblionumbers) { > $reserve{'itemnumber'} = $res->itemnumber(); > $reserve{'wbrname'} = $res->branch()->branchname(); > $reserve{'atdestination'} = $res->is_at_destination(); >- $reserve{'desk_name'} = $res->desk()->desk_name(); >+ $reserve{'desk_name'} = ( $res->desk() ) ? $res->desk()->desk_name() : '' ; > $reserve{'found'} = $res->is_found(); > $reserve{'inprocessing'} = $res->is_in_processing(); > $reserve{'intransit'} = $res->is_in_transit(); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24412
:
97328
|
97329
|
97330
|
101625
|
101626
|
101627
|
101628
|
101629
|
101630
|
101721
|
101722
|
101723
|
101825
|
101884
|
101885
|
101886
|
101898
|
101899
|
101900
|
101955
|
101956
|
101957
|
106586
|
106648
|
110067
|
110068
|
110069
|
110070
|
110450
|
110451
|
110452
|
110453
|
110454
|
110455
|
110582
|
110583
|
110584
|
110585
|
110586
|
112046
|
112047
|
112048
|
112049
|
112050
|
112092
|
112099
|
112165
|
112166
|
112167
|
112168
|
112169
|
112170
|
112171
|
112172
|
112201
|
112202
|
112203
|
112204
|
112205
|
112206
|
112207
|
112208
|
112209
|
112210
|
112211
|
112212
|
112213
|
112214
|
112215
|
112216
|
112217
|
112218
|
112219
|
112264
|
112265
|
112266
|
112267
|
112268
|
112269
|
112270
|
112271
|
112272
|
112292
|
112293
|
113108
|
113109
|
113116
|
113228
|
113229
|
113230
|
113231
|
113232
|
113233
|
113234
|
113235
|
113236