Bugzilla – Attachment 113164 Details for
Bug 14242
Use ISBN-field to fill out purchase suggestions using Google Books API
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14242: (follow-up) Adding publication year hint and fix js translations
Bug-14242-follow-up-Adding-publication-year-hint-a.patch (text/plain), 3.84 KB, created by
Aleisha Amohia
on 2020-11-05 20:06:05 UTC
(
hide
)
Description:
Bug 14242: (follow-up) Adding publication year hint and fix js translations
Filename:
MIME Type:
Creator:
Aleisha Amohia
Created:
2020-11-05 20:06:05 UTC
Size:
3.84 KB
patch
obsolete
>From 44e7be2dca3d499ffd86bc3524fb6027682cf8e4 Mon Sep 17 00:00:00 2001 >From: Aleisha Amohia <aleishaamohia@hotmail.com> >Date: Wed, 16 Sep 2020 14:55:27 +1200 >Subject: [PATCH] Bug 14242: (follow-up) Adding publication year hint and fix > js translations > >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt | 7 +++---- > koha-tmpl/opac-tmpl/bootstrap/js/autofill.js | 5 ++++- > 2 files changed, 7 insertions(+), 5 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >index 5c2236af02..e3077904a8 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt >@@ -100,13 +100,14 @@ > <li> > <div title="Copyright or publication year, for example: 2016"> > [% IF ( copyrightdate_required ) %] >- <label for="copyrightdate" class="required">Copyright date:</label> >+ <label for="copyrightdate" class="required">Publication year:</label> > <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="10" maxlength="4" value="[% copyrightdate | html %]" required="required" /> > <span class="required">Required</span> > [% ELSE %] >- <label for="copyrightdate">Copyright date:</label> >+ <label for="copyrightdate">Publication year:</label> > <input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="10" maxlength="4" value="[% copyrightdate | html %]" /> > [% END %] >+ <span class="hint">Copyright or publication year, for example: 2016</span> > </div> > </li> > [% END %] >@@ -478,8 +479,6 @@ > [% END %] > [% INCLUDE 'datatables.inc' %] > <script> >- var MSG_UNDO_AUTOFILL_SUGGESTION = _("Undo"); >- var MSG_SEARCH_GOOGLE_BOOKS = _("Search Google Books"); > [% IF ( loggedinusername ) %] > function enableCheckboxActions(){ > // Enable/disable controls if checkboxes are checked >diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js b/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js >index bdade9a575..ed70653017 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js >+++ b/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js >@@ -27,6 +27,9 @@ > self.$elm = $(elm); > self.fields = fields; > >+ var MSG_UNDO_AUTOFILL_SUGGESTION = __("Clear form"); >+ var MSG_SEARCH_GOOGLE_BOOKS = __("Search Google Books"); >+ > /* decorate element as autofiller */ > self.$undo = $('<input type="button" class="btn" style="display:none;margin-left:5px;" value="' + MSG_UNDO_AUTOFILL_SUGGESTION + '" />'); > self.$fillbtn = $('<input type="button" class="btn" value="' + MSG_SEARCH_GOOGLE_BOOKS + '" />'); >@@ -69,7 +72,7 @@ > gAPI += '&maxResults=1'; > $.getJSON(gAPI, function (response) { > if(response.totalItems == 0) { >- self.$error.html(_('Sorry, nothing found.')); >+ self.$error.html(__('Sorry, nothing found.')); > self.$error.show(); > return; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14242
:
42002
|
55949
|
56061
|
56062
|
56070
|
56071
|
56072
|
56073
|
56074
|
56075
|
84760
|
84761
|
84762
|
84763
|
84764
|
84840
|
85031
|
85032
|
85033
|
85034
|
85035
|
89643
|
89662
|
90157
|
90158
|
90159
|
90160
|
90161
|
90162
|
90250
|
90251
|
90252
|
90253
|
90254
|
90255
|
103527
|
103528
|
103529
|
103530
|
103531
|
103532
|
103533
|
108695
|
108696
|
108697
|
108698
|
108699
|
108700
|
108701
|
110141
|
110142
|
110143
|
110144
|
110145
|
110146
|
110147
|
110148
|
110493
|
110494
|
110495
|
110496
|
110497
|
110498
|
110499
|
110500
|
110501
|
110990
|
112597
|
112598
|
112599
|
112600
|
112601
|
112602
|
112603
|
112604
|
112605
|
112606
|
112607
|
113162
|
113163
|
113164
|
113165
|
113166
|
113167
|
116620
|
116712
|
116968
|
116989
|
125380
|
125381
|
125382
|
131219
|
131220
|
131221
|
131222
|
133985
|
133986
|
133987
|
133988
|
134273
|
134274
|
134275
|
134276
|
134277
|
134278