Attachment 113167 Details for Bug 14242 – Bug 14242: (follow-up) Remove well class, weird gap, fix clear form

[patch] Bug 14242: (follow-up) Remove well class, weird gap, fix clear form

Bug-14242-follow-up-Remove-well-class-weird-gap-fi.patch (text/plain), 3.98 KB, created by Aleisha Amohia on 2020-11-05 20:06:20 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2020-11-05 20:06:20 UTC

Size: 3.98 KB

patch

obsolete

>From 46e6fb3c9d3bac85f4d3da30b6916f488a07975d Mon Sep 17 00:00:00 2001
>From: Aleisha Amohia <aleishaamohia@hotmail.com>
>Date: Wed, 28 Oct 2020 15:23:05 +1300
>Subject: [PATCH] Bug 14242: (follow-up) Remove well class, weird gap, fix
> clear form
>
>---
> .../bootstrap/en/modules/opac-suggestions.tt       | 22 ++++++++--------------
> koha-tmpl/opac-tmpl/bootstrap/js/autofill.js       |  5 +++++
> 2 files changed, 13 insertions(+), 14 deletions(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 3d6d413615..2bac020eae 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -64,20 +64,14 @@
>                             [% END %]
> 
>                             <form action="/cgi-bin/koha/opac-suggestions.pl" method="post" id="add_suggestion_form">
>-                                [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>-                                <fieldset class="rows well" style="margin-bottom: 3em;padding: 5px;">
>-                                    <ol><li>
>-                                        <label for="isbn">Standard number (ISBN, ISSN or other):</label>
>-                                        <input type="text" id="isbn" name="isbn" maxlength="80" style="margin-right:10px;margin-top:10px;" size="15"/>
>-                                    </li></ol>
>-                                </fieldset>
>-                                [% END %]
>-                                    [% IF Koha.Preference('OPACSuggestionAutoFill') %]
>-                                        <fieldset class="rows well">
>-                                    [% ELSE %]
>-                                        <fieldset class="rows">
>-                                    [% END %]
>+                                <fieldset class="rows">
>                                     <ol>
>+                                        [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>+                                            <li>
>+                                                <label for="isbn">Standard number (ISBN, ISSN or other):</label>
>+                                                <input type="text" id="isbn" name="isbn" maxlength="80" style="margin-right:10px;margin-top:10px;" size="15"/>
>+                                            </li>
>+                                        [% END %]
>                                         <li>
>                                             [% IF ( title_required ) %]
>                                                 <label for="title" class="required">Title:</label>
>@@ -115,7 +109,7 @@
>                                                 </div>
>                                             </li>
>                                         [% END %]
>-                                        [% UNLESS ( isbn_hidden && Koha.Preference('OPACSuggestionAutoFill' )%]
>+                                        [% UNLESS ( isbn_hidden or Koha.Preference('OPACSuggestionAutoFill') ) %]
>                                             <li>
>                                                 [% IF ( isbn_required ) %]
>                                                     <label for="isbn" class="required">Standard number (ISBN, ISSN or other):</label>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js b/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js
>index 61bbcba97d..495de7054c 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js
>+++ b/koha-tmpl/opac-tmpl/bootstrap/js/autofill.js
>@@ -46,6 +46,11 @@
>         }
> 
>         self.$fillbtn.click(function(){
>+            /* clear fields first */
>+            for(var key in self.fields) {
>+                var field = self.fields[key];
>+                field.$target.trigger('autofill-undo');
>+            }
>             /* only allow forced update once every second */
>             if(Date.now() - self.lastupdate > 1000) {
>                 self.$elm.trigger('change');
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 14242: 42002 | 55949 | 56061 | 56062 | 56070 | 56071 | 56072 | 56073 | 56074 | 56075 | 84760 | 84761 | 84762 | 84763 | 84764 | 84840 | 85031 | 85032 | 85033 | 85034 | 85035 | 89643 | 89662 | 90157 | 90158 | 90159 | 90160 | 90161 | 90162 | 90250 | 90251 | 90252 | 90253 | 90254 | 90255 | 103527 | 103528 | 103529 | 103530 | 103531 | 103532 | 103533 | 108695 | 108696 | 108697 | 108698 | 108699 | 108700 | 108701 | 110141 | 110142 | 110143 | 110144 | 110145 | 110146 | 110147 | 110148 | 110493 | 110494 | 110495 | 110496 | 110497 | 110498 | 110499 | 110500 | 110501 | 110990 | 112597 | 112598 | 112599 | 112600 | 112601 | 112602 | 112603 | 112604 | 112605 | 112606 | 112607 | 113162 | 113163 | 113164 | 113165 | 113166 | 113167 | 116620 | 116712 | 116968 | 116989 | 125380 | 125381 | 125382 | 131219 | 131220 | 131221 | 131222 | 133985 | 133986 | 133987 | 133988 | 134273 | 134274 | 134275 | 134276 | 134277 | 134278