Attachment 113237 Details for Bug 26627 – Bug 26627: (QA follow-up) Remove only the loop causing input field

[patch] Bug 26627: (QA follow-up) Remove only the loop causing input field

Bug-26627-QA-follow-up-Remove-only-the-loop-causin.patch (text/plain), 2.33 KB, created by Joonas Kylmälä on 2020-11-06 11:18:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Joonas Kylmälä

Created: 2020-11-06 11:18:46 UTC

Size: 2.33 KB

patch

obsolete

>From c018a8a9338ebb0237944bda3eeaf97432aa0436 Mon Sep 17 00:00:00 2001
>From: =?UTF-8?q?Joonas=20Kylm=C3=A4l=C3=A4?= <joonas.kylmala@helsinki.fi>
>Date: Fri, 6 Nov 2020 13:03:12 +0200
>Subject: [PATCH] Bug 26627: (QA follow-up) Remove only the loop causing input
> field
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>The loop reported originally happened only in this one specific form
>which this commit now removes the input field from. There is no
>need to remove the barcode from all the forms (even ones that don't
>have it). Because the JavaScript tried to remove the barcode input
>field from other forms as well we got following error when clicking
>"Print slip, transfer, and confirm" for a hold that needed transfer:
>
>Uncaught TypeError: this.form.barcode is undefined
>
>Test plan:
>1) Create biblio level hold that needs a transfer
>2) Check-in the item and click "Print slip, transfer, and confirm"
>3) Notice nothing happens, apply patch & restart, notice the slip will
>be now printed
>4) Follow the test plan from commit a71596fb39
>   (Bug 26627: Print and confirming a hold can cause an infinite loop)
>
>Signed-off-by: Joonas KylmÃ¤lÃ¤ <joonas.kylmala@helsinki.fi>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 2 --
> 1 file changed, 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index b52fc5becf..5a021fac33 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -499,7 +499,6 @@
> 
>                                                 <div class="modal-footer">
>                                                     <input type="hidden" name="cancel_reserve" value="0" />
>-                                                    <input type="hidden" name="barcode" value="[% barcode | html %]" />
> 
>                                                     <button type="submit" class="btn btn-default approve" data-dismiss="modal">
>                                                         <i class="fa fa-check"></i> Confirm hold
>@@ -1084,7 +1083,6 @@
> 
>             $('.print').on("click",function(e){
>                 this.form.print_slip.value = 1;
>-                this.form.barcode.remove();
>                 this.form.submit();
>             });
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 26627: 111337 | 111635 | 111805 | 113093 | 113237 | 113249 | 113250