Bugzilla – Attachment 113249 Details for
Bug 26627
Print and confirming a hold can cause an infinite loop
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26627: (QA follow-up) Remove barcode input by id
Bug-26627-QA-follow-up-Remove-barcode-input-by-id.patch (text/plain), 1.68 KB, created by
Kyle M Hall (khall)
on 2020-11-06 13:27:03 UTC
(
hide
)
Description:
Bug 26627: (QA follow-up) Remove barcode input by id
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-11-06 13:27:03 UTC
Size:
1.68 KB
patch
obsolete
>From 2bc6cf7ca9aa269bbfcb168b6d9342ad8967fc93 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 5 Nov 2020 06:40:42 -0500 >Subject: [PATCH] Bug 26627: (QA follow-up) Remove barcode input by id > >--- > koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >index b52fc5becf..c828ea4ddd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt >@@ -499,7 +499,7 @@ > > <div class="modal-footer"> > <input type="hidden" name="cancel_reserve" value="0" /> >- <input type="hidden" name="barcode" value="[% barcode | html %]" /> >+ <input id="confirm-hold-barcode" type="hidden" name="barcode" value="[% barcode | html %]" /> > > <button type="submit" class="btn btn-default approve" data-dismiss="modal"> > <i class="fa fa-check"></i> Confirm hold >@@ -1084,7 +1084,8 @@ > > $('.print').on("click",function(e){ > this.form.print_slip.value = 1; >- this.form.barcode.remove(); >+ let barcode = document.getElementById('confirm-hold-barcode'); >+ if ( barcode ) barcode.remove(); > this.form.submit(); > }); > >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26627
:
111337
|
111635
|
111805
|
113093
|
113237
|
113249
|
113250