Attachment 113269 Details for Bug 26633 – Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row

[patch] Bug 26633: (QA follow-up) Action buttons should not remain grayed out if the same action is used multiple times in a row

Bug-26633-QA-follow-up-Action-buttons-should-not-r.patch (text/plain), 2.29 KB, created by Kyle M Hall (khall) on 2020-11-06 18:32:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-11-06 18:32:46 UTC

Size: 2.29 KB

patch

obsolete

>From 945246197f38daed8b224a73854d28fa745ffa92 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Tue, 27 Oct 2020 14:01:47 -0400
>Subject: [PATCH] Bug 26633: (QA follow-up) Action buttons should not remain
> grayed out if the same action is used multiple times in a row
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> .../prog/en/modules/admin/transfer_limits.tt         | 12 ++++++++----
> 1 file changed, 8 insertions(+), 4 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt
>index dbf812678b..d652fb987e 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/transfer_limits.tt
>@@ -359,10 +359,12 @@
>                         checkbox.attr('checked', false);
>                         $(`#spinner-${id}`).hide();
>                         checkbox.show();
>-                        $('.limit-action').removeClass('disabled');
>-                        $('#value_selector').prop('disabled',false);
>                     }
>                 },
>+                complete: function() {
>+                    $('.limit-action').removeClass('disabled');
>+                    $('#value_selector').prop('disabled',false);
>+                },
>                 error: function(xhr, status, error) {
>                     var errorMessage = xhr.status + ': ' + xhr.statusText
>                     alert('Error - ' + errorMessage);
>@@ -389,10 +391,12 @@
>                         checkbox.attr('checked', true);
>                         $(`#spinner-${id}`).hide();
>                         checkbox.show();
>-                        $('.limit-action').removeClass('disabled');
>-                        $('#value_selector').prop('disabled',false);
>                     }
>                 },
>+                complete: function() {
>+                    $('.limit-action').removeClass('disabled');
>+                    $('#value_selector').prop('disabled',false);
>+                },
>                 error: function(xhr, status, error) {
>                     var errorMessage = xhr.status + ': ' + xhr.statusText
>                     alert('Error - ' + errorMessage);
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26633: 111380 | 111381 | 112327 | 112328 | 112330 | 112437 | 112438 | 112587 | 112778 | 112779 | 112780 | 112781 | 112782 | 112923 | 112924 | 112925 | 112926 | 112927 | 112928 | 112929 | 113053 | 113265 | 113266 | 113267 | 113268 | 113269 | 113270 | 113271 | 113272 | 113273 | 113274 | 113275 | 113676 | 113677 | 113961 | 116612 | 116613 | 116952 | 116953 | 116954 | 116955 | 116956 | 116957 | 116958 | 116959 | 116960 | 116961 | 116962 | 116963 | 116964