Attachment 113310 Details for Bug 26946 – Bug 26946: Set maxlength for cash register name

[patch] Bug 26946: Set maxlength for cash register name

Bug-26946-Set-maxlength-for-cash-register-name.patch (text/plain), 2.78 KB, created by Martin Renvoize (ashimema) on 2020-11-09 13:00:05 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-11-09 13:00:05 UTC

Size: 2.78 KB

patch

obsolete

>From dd9af506ac5de6da7345ef54b2e596df3e7f6f7c Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Mon, 9 Nov 2020 12:57:13 +0000
>Subject: [PATCH] Bug 26946: Set maxlength for cash register name
>
>The cash register names is limited to 24 characters at the database
>level and so that restriction should also be reflected in the UI.
>
>Test plan
>1/ Add or Edit a cash register ( admin > accounts > cash registers )
>2/ Note that you can enter a cash register name longer than 24
>characters, but upon save the value is truncated.
>3/ Apply patch
>4/ Note you can not longer enter a cash register name longer than 24
>characters.
>5/ Signoff
>---
> .../intranet-tmpl/prog/en/modules/admin/cash_registers.tt   | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt
>index 8b4784d448..95b3c04761 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/cash_registers.tt
>@@ -75,13 +75,13 @@
> 
>                             <li>
>                                 <label for="name" class="required">Name: </label>
>-                                <input type="text" name="name" id="name" size="80" value="[% cash_register.name | html %]" class="required" />
>+                                <input type="text" name="name" id="name" size="24" maxlength="24" value="[% cash_register.name | html %]" class="required" />
>                                 <span class="required">Required</span>
>                             </li>
> 
>                             <li>
>                                 <label for="description">Description: </label>
>-                                <input type="text" name="description" id="description" value="[% cash_register.description | html %]"/>
>+                                <input type="text" name="description" id="description" size="24" value="[% cash_register.description | html %]"/>
>                             </li>
>                             <li>
>                                 <label for="branch">Library: </label>
>@@ -96,7 +96,7 @@
> 
>                             <li>
>                                 <label for="starting_float">Initial float: </label>
>-                                <input type="text" pattern='^\d+(?:\.\d{0,2})$' name="starting_float" id="starting_float" value="[% cash_register.starting_float | $Price on_editing => 1  %]" />
>+                                <input type="text" pattern='^\d+(?:\.\d{0,2})$' name="starting_float" id="starting_float" size="24" value="[% cash_register.starting_float | $Price on_editing => 1  %]" />
>                             </li>
>                         </ol>
>                    </fieldset>
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26946: 113310 | 113338 | 114269