Bugzilla – Attachment 113313 Details for
Bug 26975
Reindent authorities editor template
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26795: (follow-up) Add markup comments
Bug-26795-follow-up-Add-markup-comments.patch (text/plain), 14.73 KB, created by
Owen Leonard
on 2020-11-09 14:32:30 UTC
(
hide
)
Description:
Bug 26795: (follow-up) Add markup comments
Filename:
MIME Type:
Creator:
Owen Leonard
Created:
2020-11-09 14:32:30 UTC
Size:
14.73 KB
patch
obsolete
>From c6fe727744aa7626153bc405b09cba7dfd28c76c Mon Sep 17 00:00:00 2001 >From: Owen Leonard <oleonard@myacpl.org> >Date: Mon, 9 Nov 2020 14:07:03 +0000 >Subject: [PATCH] Bug 26795: (follow-up) Add markup comments > >This patch adds comments to the template to highlight the markup >structure. > >This patch should have no effect on the page's appearance or >functionality. > >https://bugs.koha-community.org/show_bug.cgi?id=26975 >--- > .../prog/en/modules/authorities/authorities.tt | 102 ++++++++++----------- > 1 file changed, 51 insertions(+), 51 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >index 61904625f8..2e2684077a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/authorities/authorities.tt >@@ -190,7 +190,7 @@ > [% ELSE %] > Adding authority [% authtypetext | html %] > [% END %] >- </div> >+ </div> <!-- /.breadcrumbs --> > > <div class="main container-fluid"> > <div class="row"> >@@ -215,7 +215,7 @@ > <button class="new" onclick="confirmnotdup('items'); return false;"><i class="fa fa-save"></i> No: Save as new authority</button> > </form> > </div> >- [% END %] >+ [% END # /IF duplicateauthid %] > > <form method="post" name="f" action="/cgi-bin/koha/authorities/authorities.pl"> > <input type="hidden" name="op" value="add" /> >@@ -242,7 +242,7 @@ > <a class="btn btn-default" id="cancel" href="/cgi-bin/koha/authorities/authorities-home.pl">Cancel</a> > [% END %] > </div> >- </div> >+ </div> <!-- /#toolbar --> > > <div id="authoritytabs" class="toptabs numbered"> > <ul> >@@ -270,7 +270,7 @@ > <a href="#" tabindex="1" class="tagnum" title="[% innerloo.tag_lib | html %] - Click to Expand this Tag" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;">[% innerloo.tag | html %]</a> > [% ELSE %] > <span title="[% innerloo.tag_lib | html %]">[% innerloo.tag | html %]</span> >- [% END %] >+ [% END # /IF advancedMARCEditor %] > > [% IF ( innerloo.fixedfield ) %] > <input type="text" >@@ -304,8 +304,8 @@ > size="1" > maxlength="1" > value="[% innerloo.indicator2 | html %]" /> >- [% END %] - >- [% ELSE %] >+ [% END # /IF innerloo.fixedfield %] - >+ [% ELSE # UNLESS hide_marc %] > [% IF ( innerloo.fixedfield ) %] > <input type="hidden" > tabindex="1" >@@ -324,8 +324,8 @@ > tabindex="1" > name="tag_[% innerloo.tag | html %]_indicator2_[% innerloo.index | html %][% innerloo.random | html %]" > value="[% innerloo.indicator2 | html %]" /> >- [% END %] >- [% END %] >+ [% END # /IF innerloo.fixedfield %] >+ [% END # /UNLESS hide_marc %] > > [% UNLESS advancedMARCEditor %] > <a href="#" tabindex="1" class="expandfield" onclick="ExpandField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Click to Expand this Tag">[% innerloo.tag_lib | html %]</a> >@@ -340,8 +340,8 @@ > <a href="#" tabindex="1" class="buttonMinus" onclick="UnCloneField('tag_[% innerloo.tag | html %]_[% innerloo.index | html %][% innerloo.random | html %]'); return false;" title="Delete this Tag"> > <img src="[% interface | html %]/[% theme | html %]/img/delete-tag.png" alt="Delete this Tag" /> > </a> >- </span> >- </div> >+ </span> <!-- /.field_controls --> >+ </div> <!-- /.tag_title --> > > <ul class="sortable_subfield"> > [% FOREACH subfield_loo IN innerloo.subfield_loop %] >@@ -354,7 +354,7 @@ > [% ELSE %] > <label for="tag_[% subfield_loo.tag | html %]_subfield_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" class="labelsubfield"> > [% END %] >- [% END %] >+ [% END #/UNLESS advancedMARCEditor %] > > [% UNLESS hide_marc %] > <span class="subfieldcode"> >@@ -367,12 +367,12 @@ > maxlength="1" > class="flat" > tabindex="0" /> >- </span> >+ </span> <!-- /.subfieldcode --> > [% ELSE %] > <input type="hidden" > name="tag_[% subfield_loo.tag | html %]_code_[% subfield_loo.subfield | html %]_[% subfield_loo.index | html %]_[% subfield_loo.index_subfield | html %]" > value="[% subfield_loo.subfield | html %]" /> >- [% END %] >+ [% END # /UNLESS hide_marc %] > > [% UNLESS advancedMARCEditor %] > [% IF ( subfield_loo.mandatory ) %] >@@ -386,7 +386,7 @@ > [% END %] > </span> > </label> >- [% END %] >+ [% END # /UNLESS advancedMARCEditor %] > > [% SET mv = subfield_loo.marc_value %] > [% IF ( mv.type == 'select' ) %] >@@ -423,7 +423,7 @@ > <input tabindex="1" type="hidden" id="[%- mv.id | html -%]" name="[%- mv.name | html -%]" size="67" maxlength="[%- mv.maxlength | html -%]" value="[%- mv.value | html -%]" /> > [% ELSIF ( mv.type == 'hidden_simple' ) %] > <input type="hidden" name="[%- mv.name | html -%]" /> >- [% END %] >+ [% END # /IF mv.type == ... %] > > <span class="subfield_controls"> > [% IF ( subfield_loo.repeatable ) %] >@@ -433,47 +433,47 @@ > <a href="#" class="buttonMinus" tabindex="1" onclick="UnCloneField('subfield[% subfield_loo.tag | html %][% subfield_loo.subfield | html %][% subfield_loo.random | html %]'); return false;"> > <img src="[% interface | html %]/[% theme | html %]/img/delete-subfield.png" alt="Delete" title="Delete this subfield" /> > </a> >- [% END %] >- </span> >- </li> >+ [% END # /IF subfield_loo.repeatable %] >+ </span> <!-- /.subfield_controls --> >+ </li> <!-- /.subfield_line --> > <!-- End of the line --> >- [% END %] >+ [% END # /FOREACH subfield_loo %] > </ul> <!-- /.sortable_subfield --> >- </li> >+ </li> <!-- /.tag.clearfix --> > [% END %]<!-- if innerloo.tag --> > [% END %]<!-- BIG_LOO.innerloop --> > </ul> <!-- /.sortable_field --> >- </div> >- [% END %]<!-- BIG_LOOP --> >- </div><!-- tabs --> >- >- <div name="hidden" id="hidden" class="tab"> >- [% FOREACH hidden_loo IN hidden_loop %] >- <input type="hidden" name="tag" value="[% hidden_loo.tag | html %]" /> >- <input type="hidden" name="subfield" value="[% hidden_loo.subfield | html %]" /> >- <input type="hidden" name="mandatory" value="[% hidden_loo.mandatory | html %]" /> >- <input type="hidden" name="kohafield" value="[% hidden_loo.kohafield | html %]" /> >- <input type="hidden" name="tag_mandatory" value="[% hidden_loo.tag_mandatory | html %]" /> >- [% END %] >- </div> >- >- [% IF ( oldauthnumtagfield ) %] >- <input type="hidden" name="tag" value="[% oldauthnumtagfield | html %]" /> >- <input type="hidden" name="subfield" value="[% oldauthnumtagsubfield | html %]" /> >- <input type="hidden" name="field_value" value="[% authid | html %]" /> >- <input type="hidden" name="mandatory" value="0" /> >- <input type="hidden" name="kohafield" value="[% kohafield | html %]" /> >- <input type="hidden" name="tag_mandatory" value="[% tag_mandatory | html %]" /> >- <input type="hidden" name="tag" value="[% oldauthtypetagfield | html %]" /> >- <input type="hidden" name="subfield" value="[% oldauthtypetagsubfield | html %]" /> >- <input type="hidden" name="field_value" value="[% authtypecode | html %]" /> >- [% END %] >- </form> >- >- [% INCLUDE 'modals/cataloguing_create_av.inc' %] >+ </div> <!-- /.tab[% BIG_LOO.number | html %]XX --> >+ [% END %]<!-- BIG_LOOP --> >+ </div><!-- tabs --> >+ >+ <div name="hidden" id="hidden" class="tab"> >+ [% FOREACH hidden_loo IN hidden_loop %] >+ <input type="hidden" name="tag" value="[% hidden_loo.tag | html %]" /> >+ <input type="hidden" name="subfield" value="[% hidden_loo.subfield | html %]" /> >+ <input type="hidden" name="mandatory" value="[% hidden_loo.mandatory | html %]" /> >+ <input type="hidden" name="kohafield" value="[% hidden_loo.kohafield | html %]" /> >+ <input type="hidden" name="tag_mandatory" value="[% hidden_loo.tag_mandatory | html %]" /> >+ [% END %] >+ </div> > >- </div> >- </div> >-</div> >+ [% IF ( oldauthnumtagfield ) %] >+ <input type="hidden" name="tag" value="[% oldauthnumtagfield | html %]" /> >+ <input type="hidden" name="subfield" value="[% oldauthnumtagsubfield | html %]" /> >+ <input type="hidden" name="field_value" value="[% authid | html %]" /> >+ <input type="hidden" name="mandatory" value="0" /> >+ <input type="hidden" name="kohafield" value="[% kohafield | html %]" /> >+ <input type="hidden" name="tag_mandatory" value="[% tag_mandatory | html %]" /> >+ <input type="hidden" name="tag" value="[% oldauthtypetagfield | html %]" /> >+ <input type="hidden" name="subfield" value="[% oldauthtypetagsubfield | html %]" /> >+ <input type="hidden" name="field_value" value="[% authtypecode | html %]" /> >+ [% END # /IF ( oldauthnumtagfield ) %] >+ </form> >+ >+ [% INCLUDE 'modals/cataloguing_create_av.inc' %] >+ >+ </div> <!-- /.col-md-8.col-md-offset-2 --> >+ </div> <!-- /.row --> >+ </div> <!-- .main.container-fluid --> > > [% INCLUDE 'intranet-bottom.inc' %] >-- >2.11.0
<b>You cannot view the attachment while viewing its details because your browser does not support IFRAMEs. <a href="attachment.cgi?id=113313">View the attachment on a separate page</a>.</b>
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26975
:
113312
|
113313
|
116267
|
116268
|
129279
|
129280
|
129965
|
129966
|
130636
|
130637
|
130928
|
130929
|
130930
|
131052