Bugzilla – Attachment 11335 Details for
Bug 8569
Paying for a lost item overwrites nonpublic notes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 8569: Paying for lost item overwrites nonpublic notes.
Bug-8569-Paying-for-lost-item-overwrites-nonpublic.patch (text/plain), 1.33 KB, created by
Kyle M Hall (khall)
on 2012-08-03 15:27:50 UTC
(
hide
)
Description:
Bug 8569: Paying for lost item overwrites nonpublic notes.
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2012-08-03 15:27:50 UTC
Size:
1.33 KB
patch
obsolete
>From e410fd6bd21dad05dd975ea7ddc9efd6b4feb112 Mon Sep 17 00:00:00 2001 >From: D Ruth Bavousett <ruth@bywatersolutions.com> >Date: Fri, 3 Aug 2012 07:53:23 -0700 >Subject: [PATCH] Bug 8569: Paying for lost item overwrites nonpublic notes. > >This patch modifies C4::Circulation::ReturnLostItem to append the Paid-for note >to existing data, rather than overwriting it. > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/Circulation.pm | 4 +++- > 1 files changed, 3 insertions(+), 1 deletions(-) > >diff --git a/C4/Circulation.pm b/C4/Circulation.pm >index 78915ed..8e511b9 100644 >--- a/C4/Circulation.pm >+++ b/C4/Circulation.pm >@@ -3101,10 +3101,12 @@ sub ReturnLostItem{ > > MarkIssueReturned( $borrowernumber, $itemnum ); > my $borrower = C4::Members::GetMember( 'borrowernumber'=>$borrowernumber ); >+ my $item = C4::Items::GetItem( $itemnum ); >+ my $old_note = ($item->{'paidfor'} && ($item->{'paidfor'} ne q{})) ? $item->{'paidfor'}.' / ' : q{}; > my @datearr = localtime(time); > my $date = ( 1900 + $datearr[5] ) . "-" . ( $datearr[4] + 1 ) . "-" . $datearr[3]; > my $bor = "$borrower->{'firstname'} $borrower->{'surname'} $borrower->{'cardnumber'}"; >- ModItem({ paidfor => "Paid for by $bor $date" }, undef, $itemnum); >+ ModItem({ paidfor => $old_note."Paid for by $bor $date" }, undef, $itemnum); > } > > >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8569
:
11333
| 11335