Attachment 113376 Details for Bug 23916 – Bug 23916: (follow-up) Fix unit test

[patch] Bug 23916: (follow-up) Fix unit test

Bug-23916-follow-up-Fix-unit-test.patch (text/plain), 1.62 KB, created by Tomás Cohen Arazi (tcohen) on 2020-11-10 12:00:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2020-11-10 12:00:21 UTC

Size: 1.62 KB

patch

obsolete

>From 80c5bec3f6779226b58cd9ecbbd7fcad6aedaba0 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Fri, 23 Oct 2020 11:55:44 +0100
>Subject: [PATCH] Bug 23916: (follow-up) Fix unit test
>
>This commit responds to the comment made by Katrin in comment #73. I
>have removed the lines cited as causing the contraint violation. The
>were added in the original iteration of the bug patches and, despite
>spending time trying to get to the bottom of it, I cannot figure out
>why. There are no changes in the patchset relating to Koha/Patron.pm and
>removing the lines does not cause any of the tests in files that *are*
>affected by this patchset to fail. I do not know why these lines were
>ever added in the first place, unfortunately I did not add comments
>explaining (lesson learned)!
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> t/db_dependent/Koha/Patrons.t | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t
>index 21bfb8ccd74..c2824082e7c 100755
>--- a/t/db_dependent/Koha/Patrons.t
>+++ b/t/db_dependent/Koha/Patrons.t
>@@ -1430,13 +1430,6 @@ subtest 'get_overdues' => sub {
>             value  => { branchcode => $library->{branchcode} }
>         }
>     );
>-    my $issuer = $builder->build(
>-        {
>-            source => 'Borrower',
>-            value  => { branchcode => $library->{branchcode} }
>-        }
>-    );
>-    t::lib::Mocks::mock_userenv({ number => $issuer->{borrowernumber} });
> 
>     t::lib::Mocks::mock_preference({ branchcode => $library->{branchcode} });
> 
>-- 
>2.29.2

Actions: View | Diff | Splinter Review

Attachments on bug 23916: 94914 | 94915 | 94916 | 94917 | 94918 | 95503 | 95504 | 95505 | 95506 | 95507 | 95508 | 95509 | 97719 | 97720 | 97721 | 97722 | 97723 | 97724 | 98586 | 98587 | 98588 | 98589 | 98590 | 98591 | 98594 | 99886 | 99887 | 99888 | 99889 | 99890 | 99891 | 110649 | 110650 | 110651 | 110652 | 110653 | 110654 | 110655 | 111485 | 111486 | 111487 | 111488 | 111489 | 111490 | 111491 | 111492 | 111966 | 111967 | 111968 | 111969 | 111970 | 111971 | 111972 | 111973 | 111974 | 112248 | 112249 | 112250 | 112251 | 112252 | 112253 | 112254 | 112255 | 112256 | 112257 | 112363 | 112364 | 112365 | 112366 | 112367 | 112368 | 112369 | 112370 | 112371 | 112372 | 112373 | 113035 | 113036 | 113037 | 113038 | 113039 | 113040 | 113041 | 113042 | 113043 | 113044 | 113045 | 113316 | 113317 | 113318 | 113319 | 113320 | 113321 | 113322 | 113323 | 113324 | 113325 | 113326 | 113327 | 113367 | 113368 | 113369 | 113370 | 113371 | 113372 | 113373 | 113374 | 113375 | 113376 | 113377 | 113378 | 113379 | 113380 | 113381 | 113382 | 113396