Attachment 113406 Details for Bug 22818 – Bug 22818: (QA follow-up) Translation fix + Branch notices

[patch] Bug 22818: (QA follow-up) Translation fix + Branch notices

Bug-22818-QA-follow-up-Translation-fix--Branch-not.patch (text/plain), 1.57 KB, created by Andrew Isherwood on 2020-11-10 14:18:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2020-11-10 14:18:28 UTC

Size: 1.57 KB

patch

obsolete

>From 99e60d2c1f9529b8cb7285d91f8dccb2dedbb336 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Thu, 9 Jul 2020 10:25:26 +0100
>Subject: [PATCH] Bug 22818: (QA follow-up) Translation fix + Branch notices
>
>This patch removes the hard coded 'N/A' being passed to
>GetPreparedLetter and passes in the branchcode of the ILLRequest so
>notices can be branch specific.
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> Koha/Illrequest.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/Koha/Illrequest.pm b/Koha/Illrequest.pm
>index 4a3eb566cd..6e4f64761c 100644
>--- a/Koha/Illrequest.pm
>+++ b/Koha/Illrequest.pm
>@@ -1556,6 +1556,7 @@ sub get_notice {
>     my $letter = C4::Letters::GetPreparedLetter(
>         module                 => 'ill',
>         letter_code            => $params->{notice_code},
>+        branchcode             => $self->branchcode,
>         message_transport_type => $params->{transport},
>         lang                   => $self->patron->lang,
>         tables                 => {
>@@ -1565,8 +1566,8 @@ sub get_notice {
>             branches    => $self->branchcode,
>         },
>         substitute  => {
>-            ill_bib_title      => $title ? $title->value : 'N/A',
>-            ill_bib_author     => $author ? $author->value : 'N/A',
>+            ill_bib_title      => $title ? $title->value : qw{},
>+            ill_bib_author     => $author ? $author->value : qw{},
>             ill_full_metadata  => $metastring
>         }
>     );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 22818: 89831 | 89832 | 89833 | 89834 | 89835 | 90063 | 90064 | 90065 | 90066 | 90067 | 90715 | 90716 | 90717 | 90718 | 90719 | 92898 | 92899 | 92900 | 92901 | 92902 | 100234 | 100235 | 100236 | 100237 | 100238 | 103268 | 103269 | 103270 | 103271 | 103272 | 106424 | 106425 | 106426 | 106427 | 106428 | 106675 | 106676 | 106677 | 106678 | 106679 | 106680 | 106681 | 106691 | 106693 | 106694 | 106704 | 106705 | 106706 | 106707 | 106708 | 106709 | 106710 | 106711 | 106712 | 106713 | 110196 | 110197 | 110198 | 110199 | 110201 | 110202 | 110203 | 110204 | 110205 | 110206 | 110207 | 110208 | 111837 | 111838 | 111839 | 111840 | 111841 | 111842 | 111843 | 111844 | 111845 | 111846 | 111847 | 111848 | 111874 | 111880 | 111881 | 111883 | 111884 | 111885 | 111886 | 111887 | 111888 | 111889 | 111890 | 111891 | 111892 | 111893 | 111897 | 111899 | 111900 | 111901 | 111902 | 111903 | 111904 | 111905 | 111906 | 111907 | 111908 | 111909 | 111910 | 111911 | 111912 | 111913 | 113398 | 113399 | 113400 | 113401 | 113402 | 113403 | 113404 | 113405 | 113406 | 113407 | 113408 | 113409 | 113410 | 113411 | 113412 | 113413 | 113463 | 113464 | 113465 | 113466 | 113467 | 113468 | 113469 | 113470 | 113471 | 113472 | 113473 | 113474 | 113475 | 113476 | 113477 | 113478 | 113479 | 113522 | 113549 | 113584