Attachment 11344 Details for Bug 8479 – Bug 8479 Calculate rank irrespective of display option

[patch] Bug 8479 Calculate rank irrespective of display option

Bug-8479-Calculate-rank-irrespective-of-display-op.patch (text/plain), 1.84 KB, created by Kyle M Hall (khall) on 2012-08-03 16:23:51 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2012-08-03 16:23:51 UTC

Size: 1.84 KB

patch

obsolete

>From 951f2f3aa6e76e26d29c8c4744c67409b66b25af Mon Sep 17 00:00:00 2001
>From: Colin Campbell <colin.campbell@ptfs-europe.com>
>Date: Fri, 20 Jul 2012 10:45:16 +0100
>Subject: [PATCH] Bug 8479 Calculate rank irrespective of display option
>
>Calculation of rank was being skipped based on display
>option but it is used in calculating the rank passed
>to AddReserve resulting in reserves being created with
>null priorities causing them to be skipped in subsequent
>processing
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> opac/opac-reserve.pl |   26 ++++++++++++--------------
> 1 files changed, 12 insertions(+), 14 deletions(-)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index 1fb4df0..2bbb4be 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -147,22 +147,20 @@ foreach my $biblioNumber (@biblionumbers) {
>         $itemInfoHash{$itemInfo->{itemnumber}} = $itemInfo;
>     }
> 
>-    if ($show_holds_count) {
>-        # Compute the priority rank.
>-        my ( $rank, $reserves ) = GetReservesFromBiblionumber($biblioNumber,1);
>-        $biblioData->{reservecount} = 1; # new reserve
>-        foreach my $res (@$reserves) {
>-            my $found = $res->{'found'};
>-            if ( $found && ($found eq 'W') ) {
>-                $rank--;
>-            }
>-            else {
>-                $biblioData->{reservecount}++;
>-            }
>+    # Compute the priority rank.
>+    my ( $rank, $reserves ) =
>+      GetReservesFromBiblionumber( $biblioNumber, 1 );
>+    $biblioData->{reservecount} = 1;    # new reserve
>+    foreach my $res (@{$reserves}) {
>+        my $found = $res->{found};
>+        if ( $found && $found eq 'W' ) {
>+            $rank--;
>+        }
>+        else {
>+            $biblioData->{reservecount}++;
>         }
>-        $rank++;
>-        $biblioData->{rank} = $rank;
>     }
>+    $biblioData->{rank} = $rank + 1;
> }
> 
> #
>-- 
>1.7.2.5

Actions: View | Diff | Splinter Review

Attachments on bug 8479: 11037 | 11344