Bugzilla – Attachment 113497 Details for
Bug 26990
No feedback if holds override is disabled and hold fails
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred
Bug-26990-bug-22284-follow-up-Prevent-hold-to-be-p.patch (text/plain), 1.89 KB, created by
Jonathan Druart
on 2020-11-11 14:00:24 UTC
(
hide
)
Description:
Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if cannot be transferred
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-11-11 14:00:24 UTC
Size:
1.89 KB
patch
obsolete
>From aa1115506117aa0ef48f826880492097cf151510 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 11 Nov 2020 14:55:27 +0100 >Subject: [PATCH] Bug 26990: (bug 22284 follow-up) Prevent hold to be placed if > cannot be transferred > >There is a missing parameter to CanItemBeReserved, we need to know if >the hold can be placed at a given pickup library. > >Test plan: >1 - Set preferences: > UseBranchTransferLimits: enforce > BranchTransferLimitsType: itype > AllowHoldPolicyOverride: Don't allow >2 - Set Centerville 'Book' items to not be allowed to transfer to any other library >3 - Make sure Hold policy is set to 'any library' >4 - Find a record with a Centerville item and other items >5 - Attempt to place an item level hold on the Centerville item (with a >pickup library different than Centerville) >=> Without this patch you are taken to the holds list, but your hold is not placed >Nothing indicates why hold has failed >=> With this patch you cannot select the item from Centerville >"Cannot be transferred to pickup library" >--- > reserve/request.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/reserve/request.pl b/reserve/request.pl >index 4df90a78a0..18f4943e58 100755 >--- a/reserve/request.pl >+++ b/reserve/request.pl >@@ -551,7 +551,7 @@ foreach my $biblionumber (@biblionumbers) { > > $item->{'holdallowed'} = $branchitemrule->{'holdallowed'}; > >- my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber )->{status}; >+ my $can_item_be_reserved = CanItemBeReserved( $patron->borrowernumber, $itemnumber, $pickup )->{status}; > $item->{not_holdable} = $can_item_be_reserved unless ( $can_item_be_reserved eq 'OK' ); > > $item->{item_level_holds} = Koha::CirculationRules->get_opacitemholds_policy( { item => $item_object, patron => $patron } ); >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26990
:
113497
|
113532
|
113554