Bugzilla – Attachment 113503 Details for
Bug 26963
Improve Koha::Item::pickup_locations performance
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26963: Unit tests
Bug-26963-Unit-tests.patch (text/plain), 4.59 KB, created by
Martin Renvoize (ashimema)
on 2020-11-11 15:52:41 UTC
(
hide
)
Description:
Bug 26963: Unit tests
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2020-11-11 15:52:41 UTC
Size:
4.59 KB
patch
obsolete
>From f1c2f26f60caaa332493576a08a65a4242983503 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 11 Nov 2020 01:24:15 +0000 >Subject: [PATCH] Bug 26963: Unit tests > >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> >--- > t/db_dependent/Koha/Item.t | 86 +++++++++++++++++++++++++++++++++++++- > 1 file changed, 85 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Item.t b/t/db_dependent/Koha/Item.t >index 0309fa94f6..d24416045d 100755 >--- a/t/db_dependent/Koha/Item.t >+++ b/t/db_dependent/Koha/Item.t >@@ -19,7 +19,7 @@ > > use Modern::Perl; > >-use Test::More tests => 7; >+use Test::More tests => 8; > > use C4::Biblio; > use C4::Circulation; >@@ -339,6 +339,90 @@ subtest 'pickup_locations' => sub { > $schema->storage->txn_rollback; > }; > >+subtest '_can_pickup_at' => sub { >+ plan tests =>8; >+ >+ $schema->storage->txn_begin; >+ >+ t::lib::Mocks::mock_preference('UseBranchTransferLimits', 0); >+ >+ my $library1 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } ); >+ my $library2 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } ); >+ my $library3 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 0, } } ); >+ my $library4 = $builder->build_object( { class => 'Koha::Libraries', value => { pickup_location => 1, } } ); >+ >+ my $item = $builder->build_sample_item({ >+ homebranch => $library1->branchcode, >+ holdingbranch => $library1->branchcode, >+ ccode => "Gollum" >+ }); >+ >+ my @to = ( $library1, $library2, $library3, $library4 ); >+ >+ my $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 3, "With no transfer limits we get back the libraries that are pickup locations"); >+ >+ t::lib::Mocks::mock_preference('UseBranchTransferLimits', 1); >+ t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'itemtype'); >+ $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => { >+ toBranch => $library2->branchcode, >+ fromBranch => $library1->branchcode, >+ itemtype => $item->itype, >+ ccode => undef, >+ } >+ }); >+ >+ $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 2, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library"); >+ >+ $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => { >+ toBranch => $library4->branchcode, >+ fromBranch => $library1->branchcode, >+ itemtype => $item->itype, >+ ccode => undef, >+ } >+ }); >+ >+ $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 1, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries"); >+ >+ t::lib::Mocks::mock_preference('BranchTransferLimitsType', 'ccode'); >+ $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 3, "With no transfer limits of type ccode we get back the libraries that are pickup locations"); >+ >+ $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => { >+ toBranch => $library2->branchcode, >+ fromBranch => $library1->branchcode, >+ itemtype => undef, >+ ccode => $item->ccode, >+ } >+ }); >+ >+ $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 2, "With a transfer limits we get back the libraries that are pickup locations minus 1 limited library"); >+ >+ $builder->build_object( { class => 'Koha::Item::Transfer::Limits', value => { >+ toBranch => $library4->branchcode, >+ fromBranch => $library1->branchcode, >+ itemtype => undef, >+ ccode => $item->ccode, >+ } >+ }); >+ >+ $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 1, "With 2 transfer limits we get back the libraries that are pickup locations minus 2 limited libraries"); >+ >+ >+ $pickup_locations = $item->_can_pickup_at({ to => \@to, from => $library2 }); >+ is( scalar @$pickup_locations, 3, "With transfer limits enabled but not applying because of 'from' we get back the libraries that are pickup locations"); >+ >+ t::lib::Mocks::mock_preference('UseBranchTransferLimits', 0); >+ >+ $pickup_locations = $item->_can_pickup_at({ to => \@to }); >+ is( scalar @$pickup_locations, 3, "With transfer limits disabled we get back the libraries that are pickup locations"); >+ >+}; >+ > subtest 'deletion' => sub { > plan tests => 12; > >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26963
:
113282
|
113283
|
113329
|
113330
|
113333
|
113339
|
113340
|
113419
|
113420
|
113422
|
113423
|
113424
|
113425
|
113451
|
113452
|
113453
|
113454
|
113455
|
113480
|
113481
|
113483
|
113498
|
113503
|
113504
|
113505
|
113506
|
113507
|
113508
|
113509
|
113510
|
113511
|
113512
|
113513
|
113514
|
113515
|
113516
|
113517
|
113518
|
113519
|
113520
|
113521
|
113523
|
113524
|
113525
|
113526
|
113527
|
113528
|
113529
|
113530
|
113531
|
113586
|
113729