Bugzilla – Attachment 113536 Details for
Bug 26988
Defer loading the hold pickup locations until the dropdown is selected
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26988: (follow-up) Adjust code to use api field names
Bug-26988-follow-up-Adjust-code-to-use-api-field-n.patch (text/plain), 1.48 KB, created by
Tomás Cohen Arazi (tcohen)
on 2020-11-11 19:16:24 UTC
(
hide
)
Description:
Bug 26988: (follow-up) Adjust code to use api field names
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2020-11-11 19:16:24 UTC
Size:
1.48 KB
patch
obsolete
>From 0a96395a4b646f901659936aa94c155028126e22 Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Wed, 11 Nov 2020 02:53:46 +0000 >Subject: [PATCH] Bug 26988: (follow-up) Adjust code to use api field names > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > koha-tmpl/intranet-tmpl/prog/js/holds.js | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/js/holds.js b/koha-tmpl/intranet-tmpl/prog/js/holds.js >index 748aab04c96..f6a941979de 100644 >--- a/koha-tmpl/intranet-tmpl/prog/js/holds.js >+++ b/koha-tmpl/intranet-tmpl/prog/js/holds.js >@@ -315,12 +315,12 @@ $(document).ready(function() { > success: function( data ){ > var dropdown = ""; > $.each(data, function(index,library) { >- if( preselected == library.branchcode ){ >+ if( preselected == library.library_id ){ > selected = ' selected="selected" '; > } else { selected = ""; } >- dropdown += '<option value="'+library.branchcode+'"'+selected+'>'+library.branchname+'</option>'; >+ dropdown += '<option value="'+library.library_id+'"'+selected+'>'+library.name+'</option>'; > }); >- this_dropdown.html( dropdown); >+ this_dropdown.html(dropdown); > this_dropdown.data("loaded",1); > $(".loading_"+hold_id).hide(); > }, >-- >2.29.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26988
:
113395
|
113418
|
113426
|
113427
|
113428
|
113456
|
113457
|
113458
|
113459
|
113460
|
113502
|
113533
|
113534
|
113535
| 113536 |
113537
|
113538
|
113590
|
113601
|
113669