Attachment 113557 Details for Bug 24083 – Bug 24083: (QA follow-up) Fix for previous

[patch] Bug 24083: (QA follow-up) Fix for previous

Bug-24083-QA-follow-up-Fix-for-previous.patch (text/plain), 1.51 KB, created by Andrew Isherwood on 2020-11-12 13:46:35 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Andrew Isherwood

Created: 2020-11-12 13:46:35 UTC

Size: 1.51 KB

patch

obsolete

>From 1cf113943daff6bfcd27a37f8dee6ae906400ef3 Mon Sep 17 00:00:00 2001
>From: Andrew Isherwood <andrew.isherwood@ptfs-europe.com>
>Date: Thu, 12 Nov 2020 13:45:50 +0000
>Subject: [PATCH] Bug 24083: (QA follow-up) Fix for previous
>
>It helps if you don't commit commented out code...
>---
> installer/data/mysql/updatedatabase.pl | 18 +++++++++---------
> 1 file changed, 9 insertions(+), 9 deletions(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 3bbfc677d2..2cd4b47fb3 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -23388,19 +23388,19 @@ if( CheckVersion( $DBversion ) ) {
> 
> $DBversion = '20.06.00.069';
> if( CheckVersion( $DBversion ) ) {
>-#    my ($count) = $dbh->selectrow_array(
>-#        q|
>-#            SELECT COUNT(*)
>-#            FROM circulation_rules
>-#            WHERE rule_name = 'unseen_renewals_allowed'
>-#        |
>-#    );
>-#    if ($count == 0) {
>+    my ($count) = $dbh->selectrow_array(
>+        q|
>+            SELECT COUNT(*)
>+            FROM circulation_rules
>+            WHERE rule_name = 'unseen_renewals_allowed'
>+        |
>+    );
>+    if ($count == 0) {
>         $dbh->do( q|
>             INSERT INTO circulation_rules (rule_name, rule_value)
>             VALUES ('unseen_renewals_allowed', '')
>         | );
>-#    }
>+    }
> 
>     if( !column_exists( 'issues', 'unseen_renewals' ) ) {
>         $dbh->do( q| ALTER TABLE issues ADD unseen_renewals TINYINT(4) DEFAULT 0 NOT NULL AFTER renewals | );
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 24083: 95861 | 95862 | 95863 | 95864 | 95865 | 95866 | 95867 | 95868 | 98749 | 98750 | 98751 | 98752 | 98765 | 98766 | 98767 | 98768 | 100244 | 100245 | 100246 | 100247 | 100380 | 100381 | 100382 | 100383 | 100392 | 110607 | 110608 | 110609 | 110610 | 110611 | 111147 | 111148 | 111149 | 111150 | 111151 | 111152 | 111283 | 111284 | 111285 | 111286 | 111287 | 111288 | 111289 | 111290 | 111291 | 111292 | 111293 | 111849 | 111850 | 111851 | 111852 | 111853 | 111854 | 111855 | 111856 | 111857 | 111858 | 111859 | 111860 | 112230 | 112231 | 112232 | 112233 | 112234 | 112235 | 112236 | 112237 | 112238 | 112239 | 112240 | 112241 | 112242 | 112243 | 112410 | 112411 | 112412 | 112413 | 112414 | 112415 | 112416 | 112417 | 112418 | 112419 | 112420 | 112421 | 112422 | 112423 | 113073 | 113074 | 113075 | 113076 | 113077 | 113078 | 113079 | 113080 | 113314 | 113315 | 113484 | 113485 | 113486 | 113487 | 113488 | 113489 | 113490 | 113491 | 113492 | 113493 | 113494 | 113546 | 113556 | 113557 | 113814