Attachment 113572 Details for Bug 26351 – Bug 26351: (QA follow-up) Fix QA script issue

[patch] Bug 26351: (QA follow-up) Fix QA script issue

Bug-26351-QA-follow-up-Fix-QA-script-issue.patch (text/plain), 1.03 KB, created by Kyle M Hall (khall) on 2020-11-12 17:30:45 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-11-12 17:30:45 UTC

Size: 1.03 KB

patch

obsolete

>From 8cb77cc25965a6337a1cac1c033c886a13ee1f83 Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Fri, 4 Sep 2020 11:28:25 -0400
>Subject: [PATCH] Bug 26351: (QA follow-up) Fix QA script issue
>
>* Fixes issue with barcode generate stub so perlcritic is happy
>* Removes extra semicolon from return call in configure method
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> t/lib/Koha/Plugin/Test.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/t/lib/Koha/Plugin/Test.pm b/t/lib/Koha/Plugin/Test.pm
>index c3ae8c7f5b..a8cf2a5915 100644
>--- a/t/lib/Koha/Plugin/Test.pm
>+++ b/t/lib/Koha/Plugin/Test.pm
>@@ -99,12 +99,13 @@ sub barcode_transform {
> }
> 
> sub barcode_generate {
>-    my ( $self, $type, $object )
>+    my ( $self, $type, $object ) = @_;
>+    return "Koha::Plugin::Test::barcode_generate";
> }
> 
> sub configure {
>     my ( $self, $args ) = @_;
>-    return "Koha::Plugin::Test::configure";;
>+    return "Koha::Plugin::Test::configure";
> }
> 
> sub install {
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 26351: 109532 | 109548 | 109671 | 110844 | 110846 | 111575 | 111577 | 111578 | 111579 | 111862 | 111863 | 111894 | 111916 | 111917 | 111918 | 111919 | 111920 | 111921 | 111922 | 113571 | 113572 | 113573 | 113574 | 113575 | 113576 | 113577 | 113578 | 115172 | 115173 | 115174 | 115175 | 115176 | 115177 | 115178 | 115179 | 115180 | 118649 | 118650 | 118651 | 118652 | 118653 | 118654 | 118655 | 118656 | 118657 | 118658 | 118681 | 118682 | 118683 | 118684 | 118685 | 118686 | 118687 | 118688 | 118689 | 118690 | 122433 | 122434 | 122435 | 122436 | 122437 | 122438 | 122439 | 122440 | 122441 | 122442 | 124258 | 124259 | 124260 | 124261 | 124262 | 124263 | 124264 | 124265 | 124266 | 124313 | 125447 | 125763 | 125764 | 125765