Bugzilla – Attachment 11361 Details for
Bug 8547
Enabling star ratings causes javascript errors that cause IE to have a boo boo
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 8547 - JS error in star ratings breaks IE
SIGNED-OFF-Bug-8547---JS-error-in-star-ratings-bre.patch (text/plain), 1.18 KB, created by
Marc Véron
on 2012-08-04 22:00:34 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 8547 - JS error in star ratings breaks IE
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2012-08-04 22:00:34 UTC
Size:
1.18 KB
patch
obsolete
>From 06486d632f88ba093409a737e0f749cb641a7efd Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Wed, 1 Aug 2012 14:23:14 +0200 >Subject: [PATCH] [SIGNED-OFF] Bug 8547 - JS error in star ratings breaks IE >Content-Type: text/plain; charset="utf-8" > >Writing code with best practices in mind breaks IE. Thanks Internet >Explorer. Now go DiaF. > >Signed-off-by: Marc Veron <veron@veron.ch> > >Tested with with IE 7.0.5730.13 on Windows XP, no JS errors, stars display and behave as expected >--- > koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >index 54ed48e..75f16aa 100644 >--- a/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/prog/en/modules/opac-detail.tt >@@ -112,7 +112,7 @@ $(function () { > borrowernumber: "[% borrowernumber %]", > biblionumber: "[% biblionumber %]", > rating_value: value, >- auth_error: value, >+ auth_error: value > }, function (data) { > > if (data.auth_status != 'ok') { >-- >1.7.2.5
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 8547
:
11251
| 11361