Bugzilla – Attachment 113696 Details for
Bug 24488
Holds to Pull sometimes shows the wrong 'first patron' details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 24488: Fix reserve.reserve_id' isn't in GROUP BY
Bug-24488-Fix-reservereserveid-isnt-in-GROUP-BY.patch (text/plain), 1.43 KB, created by
Josef Moravec
on 2020-11-17 10:47:50 UTC
(
hide
)
Description:
Bug 24488: Fix reserve.reserve_id' isn't in GROUP BY
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2020-11-17 10:47:50 UTC
Size:
1.43 KB
patch
obsolete
>From b4610ef8b953ec2bc6df11cc8fe14a1270308865 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 23 Jul 2020 08:58:04 +0200 >Subject: [PATCH] Bug 24488: Fix reserve.reserve_id' isn't in GROUP BY > >Signed-off-by: Michal Denar <black23@gmail.com> > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > circ/pendingreserves.pl | 10 +++++----- > 1 file changed, 5 insertions(+), 5 deletions(-) > >diff --git a/circ/pendingreserves.pl b/circ/pendingreserves.pl >index 3f35ddb96f..2500160dd7 100755 >--- a/circ/pendingreserves.pl >+++ b/circ/pendingreserves.pl >@@ -20,6 +20,7 @@ > use Modern::Perl; > > use constant PULL_INTERVAL => 2; >+use List::MoreUtils qw( uniq ); > > use C4::Context; > use C4::Output; >@@ -183,16 +184,15 @@ if ( C4::Context->preference('IndependentBranches') ){ > } > > # get all distinct unfulfilled reserves >-my @distinct_holds = Koha::Holds->search( >+my $distinct_holds = Koha::Holds->search( > { %where }, >- { join => 'itembib', group_by => 'reserve.biblionumber', alias => 'reserve' } >+ { join => 'itembib', alias => 'reserve' } > ); >+my @biblionumbers = uniq $distinct_holds->get_column('biblionumber'); > > # make final reserves hash and fill with info > my $reserves; >-foreach my $dh ( @distinct_holds ){ >- >- my $bibnum = $dh->biblionumber; >+foreach my $bibnum ( @biblionumbers ){ > > my @items = Koha::Items->search({ biblionumber => $bibnum }); > foreach my $i ( @items ){ >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 24488
:
97773
|
106379
|
106882
|
107206
|
107213
|
111341
|
111342
|
111343
|
111347
|
111348
|
111349
|
111350
|
111358
|
111359
|
111360
|
111361
|
111362
|
112815
|
112816
|
112817
|
112818
|
112819
|
113695
|
113696
|
113697
|
113698
|
113699
|
113700
|
113756
|
113757
|
113763
|
113764
|
113774
|
113775
|
113776
|
113777
|
113778
|
113798
|
113829
|
113830
|
113831
|
113832
|
113833
|
113834
|
113835
|
113836
|
113837
|
113838
|
113839
|
113840
|
113841
|
113842
|
113850
|
113851
|
113852
|
113853
|
113854
|
113855
|
113856
|
113857
|
113858
|
113859
|
113860
|
113861
|
113862
|
113863
|
113864
|
114835
|
114836
|
114837
|
114838
|
114839
|
114840
|
114841
|
114842
|
114843
|
114844
|
114845
|
114846
|
114847
|
114848
|
114849
|
114850
|
116362
|
116363
|
116364
|
116365
|
116366
|
116367
|
116368
|
116369
|
116370
|
116371
|
116372
|
116373
|
116374
|
116375
|
116376
|
116377
|
116384