Bugzilla – Attachment 113749 Details for
Bug 25954
Header search forms should be labeled
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25954: (QA follow-up) Correct label "for" attribute in authorities search
Bug-25954-QA-follow-up-Correct-label-for-attribute.patch (text/plain), 3.05 KB, created by
Josef Moravec
on 2020-11-17 17:39:36 UTC
(
hide
)
Description:
Bug 25954: (QA follow-up) Correct label "for" attribute in authorities search
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2020-11-17 17:39:36 UTC
Size:
3.05 KB
patch
obsolete
>From c26eb3967bae5fe1f9f60fd66af733fc68aa430f Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 17 Nov 2020 17:34:12 +0000 >Subject: [PATCH] Bug 25954: (QA follow-up) Correct label "for" attribute in > authorities search > >Change it from first select box to text input for consistancy with other >search forms > >Test plan: >1) Apply the patch >2) Go to authorities search >3) Confirm the labels in all search tabs are linked to text input field > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >index 06e6b5b196..13474f87c1 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/authorities-search.inc >@@ -4,7 +4,7 @@ > <div id="header_search" class="residentsearch"> > <div id="mainmain_heading" class="residentsearch"> > <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get"> >- <label class="tip" for="authtype_main_heading_a">Enter main heading ($a only):</label> >+ <label class="tip" for="value_mainentry">Enter main heading ($a only):</label> > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode" id="authtype_main_heading_a"> >@@ -60,7 +60,7 @@ > </div> > <div id="main_heading" class="residentsearch"> > <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get"> >- <label class="tip" for="authtype_main_heading">Enter main heading:</label> >+ <label class="tip" for="value_mainheading">Enter main heading:</label> > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode" id="authtype_main_heading"> >@@ -116,7 +116,7 @@ > </div> > <div id="matchheading_search" class="residentsearch"> > <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get"> >- <label class="tip" for="authtype_all_headings">Enter any heading:</label> >+ <label class="tip" for="value_matchheading">Enter any heading:</label> > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode" id="authtype_all_headings"> >@@ -170,7 +170,7 @@ > </div> > <div id="entire_record" class="residentsearch"> > <form action="/cgi-bin/koha/authorities/authorities-home.pl" method="get"> >- <label class="tip" for="authtype_entire_record">Enter any authority field:</label> >+ <label class="tip" for="value_anywhere">Enter any authority field:</label> > <input type="hidden" name="op" value="do_search" /> > <input type="hidden" name="type" value="intranet" /> > <select name="authtypecode" id="authtype_entire_record"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25954
:
106659
|
107896
|
107900
|
107915
|
107986
|
113747
|
113748
|
113749
|
114681
|
114682
|
114683
|
114790