Bugzilla – Attachment 113787 Details for
Bug 27051
opac-library.tt should include email
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26986: Prevent Selenium's StaleElementReferenceException
Bug-26986-Prevent-Seleniums-StaleElementReferenceE.patch (text/plain), 2.30 KB, created by
Lucas Gass (lukeg)
on 2020-11-18 14:49:54 UTC
(
hide
)
Description:
Bug 26986: Prevent Selenium's StaleElementReferenceException
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2020-11-18 14:49:54 UTC
Size:
2.30 KB
patch
obsolete
>From 2c3967b1157f29eec50e49afe3289759ecf1c44c Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 10 Nov 2020 11:37:55 +0100 >Subject: [PATCH] Bug 26986: Prevent Selenium's StaleElementReferenceException > >Test plan: >1. Add some branch emails via /cgi-bin/koha/admin/branches.pl >2. Go to the OPAC and opac-library.pl, notice there emails are not listed >3. Apply patch >4. Reloda opac-library.pl and you should see the branch email addresses. > >This is a follow-up bug for bug 26162 > >By finding the element before the click I hope to get the good element, >even if the page changed in the meanwhile. > >Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net> >Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> > >https://bugs.koha-community.org/show_bug.cgi?id=27051 >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt | 3 +++ > t/lib/Selenium.pm | 2 +- > 2 files changed, 4 insertions(+), 1 deletion(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt >index bd9a7744aa..40198ba1ab 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-library.tt >@@ -56,6 +56,9 @@ > [% IF ( library.branchfax ) %] > <p>Fax: <span property="faxNumber">[% library.branchfax | html %]</span></p> > [% END %] >+ [% IF ( library.branchemail ) %] >+ <p>Email: <a href="mailto:[% library.branchemail | url %]" property="email">[% library.branchemail | html %]</a></p> >+ [% END %] > [% IF ( library.branchurl ) %] > <p><a href="[% library.branchurl | url %]" property="url">[% library.branchurl | html %]</a></p> > [% END %] >diff --git a/t/lib/Selenium.pm b/t/lib/Selenium.pm >index 758470b668..261502aae1 100644 >--- a/t/lib/Selenium.pm >+++ b/t/lib/Selenium.pm >@@ -218,7 +218,7 @@ sub click_when_visible { > my $clicked; > $self->remove_error_handler; > while ( not $clicked ) { >- eval { $elt->click }; >+ eval { $self->driver->find_element($xpath_selector)->click }; > $clicked = !$@; > $self->driver->pause(1000) unless $clicked; > } >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27051
:
113787
|
113788