Bugzilla – Attachment 113812 Details for
Bug 26031
www/search_utf8.t is failing randomly and must be removed/replaced
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26031: Remove the failing tests and the diag
Bug-26031-Remove-the-failing-tests-and-the-diag.patch (text/plain), 2.29 KB, created by
Jonathan Druart
on 2020-11-19 13:26:57 UTC
(
hide
)
Description:
Bug 26031: Remove the failing tests and the diag
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2020-11-19 13:26:57 UTC
Size:
2.29 KB
patch
obsolete
>From 37eefc1c98b53e432c0d2efd49df7eae22690a80 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Thu, 19 Nov 2020 14:24:59 +0100 >Subject: [PATCH] Bug 26031: Remove the failing tests and the diag > >--- > t/db_dependent/www/search_utf8.t | 11 ----------- > 1 file changed, 11 deletions(-) > >diff --git a/t/db_dependent/www/search_utf8.t b/t/db_dependent/www/search_utf8.t >index d98c921716..28f5801030 100755 >--- a/t/db_dependent/www/search_utf8.t >+++ b/t/db_dependent/www/search_utf8.t >@@ -256,14 +256,6 @@ sub test_search{ > $agent->field('q', $search_key); > $agent->click(); > my $intra_text = $agent->text() ; >- my $diag = sub { >- my $pref = 'XSLTResultsDisplay'; >- my $xslt_file = C4::Context->preference('marcflavour') . 'slim2intranetResults.xsl'; >- my $xslt_filepath = C4::XSLT::_get_best_default_xslt_filename( C4::Context->config('intrahtdocs'), C4::Context->preference("template"), 'en', $xslt_file ); >- return sprintf( "===DIAG===\n%s is %s\n%s %s\n==========", $pref, C4::Context->preference($pref), $xslt_filepath, ( -f $xslt_filepath ? 'exists' : 'does not exist' )); >- }; >- >-# like( $intra_text, qr|Publication details: $publisher|, ) or diag($diag->()); > > $agent->get_ok( "$intranet/cgi-bin/koha/catalogue/search.pl" , "got search on intranet"); > $agent->form_number(5); >@@ -272,7 +264,6 @@ sub test_search{ > $agent->click(); > $intra_text = $agent->text(); > >-# like( $intra_text, qr|Publication details: $publisher|, ); > my $expected_base = q|search.pl\?advsearch=1&idx=kw&q=| . uri_escape_utf8( $publisher ); > $agent->base_like(qr|$expected_base|, ); > >@@ -286,7 +277,6 @@ sub test_search{ > $agent->field( 'idx', '' ); > $agent->click( ); > my $opac_text = $agent->text() ; >-# like( $opac_text, qr|Publication details: $publisher|, ); > > $agent->get_ok( "$opac" , "got opac"); > $agent->form_name('searchform'); >@@ -295,7 +285,6 @@ sub test_search{ > $agent->click(); > $opac_text = $agent->text(); > >-# like( $opac_text, qr|Publication details: $publisher|, ); > $expected_base = q|opac-search.pl\?(idx=&)?q=| . uri_escape_utf8( $publisher ); > $agent->base_like(qr|$expected_base|, ); > # Test added on BZ 14909 in addition to making the empty idx= optional >-- >2.20.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26031
:
108780
|
108798
|
113793
|
113796
|
113811
| 113812