Attachment 113866 Details for Bug 27061 – Bug 27061: Remove duplicate permission check in svc/mana/search

[patch] Bug 27061: Remove duplicate permission check in svc/mana/search

Bug-27061-Remove-duplicate-permission-check-in-svc.patch (text/plain), 1023 bytes, created by Jonathan Druart on 2020-11-20 08:06:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-11-20 08:06:02 UTC

Size: 1023 bytes

patch

obsolete

>From 4df566b8de52832ba30c1bfac950f8e7a4910915 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 20 Nov 2020 09:04:30 +0100
>Subject: [PATCH] Bug 27061: Remove duplicate permission check in
> svc/mana/search
>
>There is a call to check_cookie_auth then another one to get_template_and_user
>
>Test plan:
>Use mana to create new report and new subscription.
>Confirm that you need the necessary permissions to use it
>---
> svc/mana/search | 7 -------
> 1 file changed, 7 deletions(-)
>
>diff --git a/svc/mana/search b/svc/mana/search
>index 03d804d9d2..3d8511a458 100755
>--- a/svc/mana/search
>+++ b/svc/mana/search
>@@ -41,13 +41,6 @@ else {
>     $flagsrequired = { serials => 'create_subscription' };
> }
> 
>-my ( $auth_status, $sessionID ) =
>-  check_cookie_auth( $input->cookie('CGISESSID'), $flagsrequired );
>-
>-if ( $auth_status ne "ok" ) {
>-    exit 0;
>-}
>-
> my ( $template, $loggedinuser, $cookie ) = get_template_and_user(
>     {
>         template_name   => $templatename,
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27061: 113866 | 119952 | 120324