Attachment 113867 Details for Bug 25583 – Bug 25583: Disable the "claim returned" button if the feature is disabled

[patch] Bug 25583: Disable the "claim returned" button if the feature is disabled

Bug-25583-Disable-the-claim-returned-button-if-the.patch (text/plain), 1.85 KB, created by Jonathan Druart on 2020-11-20 08:20:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-11-20 08:20:52 UTC

Size: 1.85 KB

patch

obsolete

>From 5dcdafb8db5d1cf8974f512b5e1be7082ffcae91 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Fri, 20 Nov 2020 09:18:26 +0100
>Subject: [PATCH] Bug 25583: Disable the "claim returned" button if the feature
> is disabled
>
>It's possible to display the "Return claims" column on the checkout
>list, even if the feature is disabled.
>We should disable the link and add an explanation.
>
>Test plan:
>- Make sure ClaimReturnedLostValue is empty
>- Go to a patron account
>- Check out an item
>- Make the claims returned column visible in the table of checkouts
>=> The button is disabled and a tooltip explains that the feature is
>disabled
>---
> koha-tmpl/intranet-tmpl/prog/js/checkouts.js | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>index f3cb49611b..45f82d6fcc 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/checkouts.js
>@@ -588,8 +588,10 @@ $(document).ready(function() {
> 
> if ( oObj.return_claim_id ) {
> content = '' + oObj.return_claim_created_on_formatted + '';
>- } else {
>+ } else if ( ClaimReturnedLostValue ) {
> content = '<a class="btn btn-default btn-xs claim-returned-btn" data-itemnumber="' + oObj.itemnumber + '"> ' + __("Claim returned") + '</a>';
>+ } else {
>+ content = '<a class="btn btn-default btn-xs" disabled="disabled" title="Claim returned is disabled"> ' + __("Claim returned") + '</a>';
> }
> return content;
> }
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 25583: 113867 | 113878 | 114108 | 114245 | 114276