Bugzilla – Attachment 113892 Details for
Bug 25552
Add missing Claims Returned option to MarkLostItemsAsReturned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee
Bug-25552-Mark-issue-as-returned-if-MarkLostItemsA.patch (text/plain), 1.46 KB, created by
Kyle M Hall (khall)
on 2020-11-20 14:33:51 UTC
(
hide
)
Description:
Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, even if not charging a lost fee
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-11-20 14:33:51 UTC
Size:
1.46 KB
patch
obsolete
>From 051bf69870aac4db2fdf980f0db15fff2839a9fc Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 4 Jun 2020 11:17:35 -0400 >Subject: [PATCH] Bug 25552: Mark issue as returned if MarkLostItemsAsReturned, > even if not charging a lost fee > >--- > Koha/Checkout.pm | 9 ++++++++- > 1 file changed, 8 insertions(+), 1 deletion(-) > >diff --git a/Koha/Checkout.pm b/Koha/Checkout.pm >index 944c0b1d73..6af0179fe5 100644 >--- a/Koha/Checkout.pm >+++ b/Koha/Checkout.pm >@@ -24,6 +24,7 @@ use Carp; > use DateTime; > use Try::Tiny; > >+use C4::Circulation qw(MarkIssueReturned); > use Koha::Checkouts::ReturnClaims; > use Koha::Database; > use Koha::DateUtils; >@@ -175,7 +176,13 @@ sub claim_returned { > $ClaimReturnedChargeFee eq 'charge' ? 1 > : $ClaimReturnedChargeFee eq 'no_charge' ? 0 > : $charge_lost_fee; # $ClaimReturnedChargeFee eq 'ask' >- C4::Circulation::LostItem( $self->itemnumber, 'claim_returned' ) if $charge_lost_fee; >+ >+ if ( $charge_lost_fee ) { >+ C4::Circulation::LostItem( $self->itemnumber, 'claim_returned' ); >+ } >+ elsif ( C4::Context->preference( 'MarkLostItemsAsReturned' ) =~ m/claim_returned/ ) { >+ C4::Circulation::MarkIssueReturned( $self->borrowernumber, $self->itemnumber, undef, $self->patron->privacy ); >+ } > > return $claim; > } >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 25552
:
105146
|
105389
|
105558
|
105559
|
105643
|
113889
|
113892
|
113893
|
113898
|
115685
|
115686
|
115687
|
115688
|
115689
|
116173