Attachment 113965 Details for Bug 27082 – Bug 27082: (bug 23013 follow-up) Remove pagination from uncertain prices

[patch] Bug 27082: (bug 23013 follow-up) Remove pagination from uncertain prices

Bug-27082-bug-23013-follow-up-Remove-pagination-fr.patch (text/plain), 1.93 KB, created by David Nind on 2020-11-24 19:38:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: David Nind

Created: 2020-11-24 19:38:50 UTC

Size: 1.93 KB

patch

obsolete

>From 05e86b26effc2c2e443cf2c871da88c598b80a82 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 24 Nov 2020 12:19:32 +0100
>Subject: [PATCH] Bug 27082: (bug 23013 follow-up) Remove pagination from
> uncertain prices
>
>When more than 20 orders with uncertain prices are displayed on the
>"uncertain prices" view, the pagination is displayed and will cause data
>loss if the form is submitted.
>
>The pagination is there since:
>  commit 247dca306407ac9568344a0a37aca3bbcffc2468
>  Bug 23013: Upgrade DataTables in the staff client
>
>What's happening:
>When the form is submitted, all the orders with uncertain price are processed, but the posted values only contain the ones from the first page of the table.
>The orders that are not displayed on the first page will have their prices fields and uncertainprice set to NULL.
>
>Test plan:
>1- create a basket
>2- add more of 20 orders with uncertain price
>3- click on uncertain price button
>4- click on save button
>=> There is no more pagination and the form behaves correctly
>
>Signed-off-by: David Nind <david@davidnind.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>index 20f1fbe302..16c5a5db75 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/uncertainprice.tt
>@@ -148,7 +148,7 @@
>                 "aoColumnDefs": [
>                     { "aTargets": [ -1, -2, -3 ], "bSortable": false, "bSearchable": false },
>                 ],
>-                "sPaginationType": "full"
>+                "sPaginationType": "four_button"
>             }));
>             $(".check_uncertain").on("change",function(){
>                 var form = document.getElementById("uncertainprices");
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27082: 113940 | 113965 | 113969 | 113977