Attachment 114052 Details for Bug 26336 – Bug 26336: Disable 'Item processing' dropdown if no item

[patch] Bug 26336: Disable 'Item processing' dropdown if no item

Bug-26336-Disable-Item-processing-dropdown-if-no-i.patch (text/plain), 1.66 KB, created by Victor Grousset/tuxayo on 2020-11-29 12:09:14 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2020-11-29 12:09:14 UTC

Size: 1.66 KB

patch

obsolete

>From 79b1cb60cfb3fcedfca0b765e3bf77e866203fdc Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 1 Sep 2020 15:47:27 +0200
>Subject: [PATCH] Bug 26336: Disable 'Item processing' dropdown if no item
>
>If there is no item to process and they have been ignored during the
>stage step, we should not let the user modify the dropdown value
>
>Test plan:
>0 - Check the count of import_items
>    SELECT COUNT(*) FROM import_items;
>1 - Import a marc file with items , process the items
>2 - Check the count of import items, it has increased
>3 - Stage the file again, do not process items
>4 - Count of import_items has not increased
>5 - Manage the stage batch
>Confirm that you cannot modify the "Item processing" value
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> .../intranet-tmpl/prog/en/includes/tools-item-action.inc    | 6 +++++-
> 1 file changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/tools-item-action.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-item-action.inc
>index 9b5486980d..b021b541fe 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/tools-item-action.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/tools-item-action.inc
>@@ -1,4 +1,8 @@
>-          <select name="item_action" id="item_action">
>+        [% IF item_action_ignore AND num_items == 0 %]
>+            <select name="item_action" id="item_action" disabled="disabled">
>+        [% ELSE %]
>+            <select name="item_action" id="item_action">
>+        [% END %]
>             [% IF ( item_action_always_add ) %]
>                 <option value="always_add" selected="selected">
>             [% ELSE %]
>-- 
>2.29.2

Actions: View | Diff | Splinter Review

Attachments on bug 26336: 109434 | 109445 | 114052 | 114053 | 114065 | 114066