Attachment 114070 Details for Bug 21886 – Bug 21886: (QA follow-up) Update parameters

[patch] Bug 21886: (QA follow-up) Update parameters

Bug-21886-QA-follow-up-Update-parameters.patch (text/plain), 2.57 KB, created by Nick Clemens (kidclamp) on 2020-12-01 13:24:46 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-12-01 13:24:46 UTC

Size: 2.57 KB

patch

obsolete

>From 569234e5106804153082f9777504d09874911689 Mon Sep 17 00:00:00 2001
>From: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>Date: Wed, 4 Nov 2020 13:19:08 +0000
>Subject: [PATCH] Bug 21886: (QA follow-up) Update parameters
>
>As discussed, this patch updates the --owning parameter to more clearly
>represent it's function.
>
>--owning boolean => --frombranch=item-homebranch|item-issuebranch
>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> misc/cronjobs/advance_notices.pl | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
>diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl
>index f514c6f916..c1a95b4870 100755
>--- a/misc/cronjobs/advance_notices.pl
>+++ b/misc/cronjobs/advance_notices.pl
>@@ -131,9 +131,11 @@ select notices for one specific library. Use the value in the
> branches.branchcode table. This option can be repeated in order
> to select notices for a group of libraries.
> 
>-=item B<--owning>
>+=item B<--frombranch>
> 
>-Use the address information from the item homebranch library instead of the issuing library.
>+Set the from address for the notice to one of 'item-homebranch' or 'item-issuebranch'.
>+
>+Defaults to 'item-issuebranch'
> 
> =back
> 
>@@ -202,7 +204,7 @@ my $maxdays     = 30;                                               # -e: the En
> my $verbose     = 0;                                                # -v: verbose
> my $digest_per_branch = 0;                                          # -digest-per-branch: Prepare and send digests per branch
> my @branchcodes; # Branch(es) passed as parameter
>-my $owning_library = 0;
>+my $frombranch   = 'item-issuebranch';
> my $itemscontent = join(',',qw( date_due title author barcode ));
> 
> my $help    = 0;
>@@ -212,7 +214,7 @@ GetOptions(
>             'help|?'         => \$help,
>             'man'            => \$man,
>             'library=s'      => \@branchcodes,
>-            'owning'         => \$owning_library,
>+            'frombranch'     => \$frombranch,
>             'c'              => \$confirm,
>             'n'              => \$nomail,
>             'm:i'            => \$maxdays,
>@@ -245,6 +247,11 @@ if (@branchcodes) {
>     %branches = map { $_ => 1 } @branchcodes;
> }
> 
>+die "--frombranch takes item-homebranch or item-issuebranch only"
>+  unless ( $frombranch eq 'item-issuebranch'
>+    || $frombranch eq 'item-homebranch' );
>+my $owning_library = ( $frombranch eq 'item-homebranch' ) ? 1 : 0;
>+
> # The fields that will be substituted into <<items.content>>
> my @item_content_fields = split(/,/,$itemscontent);
> 
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 21886: 82668 | 86513 | 111581 | 111582 | 111679 | 111711 | 111828 | 111872 | 111873 | 112990 | 114068 | 114069 | 114070 | 114071