Attachment 114088 Details for Bug 26956 – Bug 26956: Allow guarantor's controls to be set when a guarantee is created

[patch] Bug 26956: Allow guarantor's controls to be set when a guarantee is created

Bug-26956-Allow-guarantors-controls-to-be-set-when.patch (text/plain), 2.97 KB, created by Jonathan Druart on 2020-12-02 09:37:22 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-12-02 09:37:22 UTC

Size: 2.97 KB

patch

obsolete

>From bb758538e21587673ecbad2054b4fe172b72d87e Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 2 Dec 2020 10:34:50 +0100
>Subject: [PATCH] Bug 26956: Allow guarantor's controls to be set when a
> guarantee is created
>
>With AllowStaffToSetCheckoutsVisibilityForGuarantor and
>AllowStaffToSetFinesVisibilityForGuarantor set to Allow, one can only see the
>controls for these values in the patron record *after* the patron has been saved
>with a guarantor. That makes a frustrating 2-step process. We should be able to
>set those values regardless of whether or not there is currently a guarantor on
>the account.
>
>Test plan:
>Create a guarantee and confirm that the 2 options "Show checkouts to
>guarantors" and "Show fines to guarantors" are displayed
>Select Yes, save
>Confirm that the values have been correctly saved
>---
> .../intranet-tmpl/prog/en/modules/members/memberentrygen.tt   | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>index 2db0de5408..60aecfe116 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt
>@@ -533,7 +533,7 @@ legend:hover {
>                                                     <a href="#" id="guarantor_search" class="btn btn-default"><i class="fa fa-plus"></i> Add guarantor</a>
>                                                 </li>
> 
>-                                                [% IF relationships && Koha.Preference('AllowStaffToSetCheckoutsVisibilityForGuarantor') %]
>+                                                [% IF Koha.Preference('AllowStaffToSetCheckoutsVisibilityForGuarantor') %]
>                                                     <li>
>                                                         <label for="privacy_guarantor_checkouts">Show checkouts to guarantors</label>
>                                                         <select name="privacy_guarantor_checkouts" id="privacy_guarantor_checkouts">
>@@ -548,7 +548,7 @@ legend:hover {
>                                                         <div class="hint">Allow guarantors of this patron to view this patron's checkouts from the OPAC</div>
>                                                     </li>
>                                                 [% END %]
>-                                                [% IF relationships && Koha.Preference('AllowStaffToSetFinesVisibilityForGuarantor') %]
>+                                                [% IF Koha.Preference('AllowStaffToSetFinesVisibilityForGuarantor') %]
>                                                     <li>
>                                                         <label for="privacy_guarantor_fines">Show fines to guarantors</label>
>                                                         <select name="privacy_guarantor_fines" id="privacy_guarantor_fines">
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26956: 114088 | 114294 | 114704