Bugzilla – Attachment 114104 Details for
Bug 27130
Adding local cover image at item level shows 'File type' section
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27130: Don't display itemnumber under "File type" section
Bug-27130-Dont-display-itemnumber-under-File-type-.patch (text/plain), 3.44 KB, created by
Fridolin Somers
on 2020-12-02 16:09:19 UTC
(
hide
)
Description:
Bug 27130: Don't display itemnumber under "File type" section
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2020-12-02 16:09:19 UTC
Size:
3.44 KB
patch
obsolete
>From b314ba3b02299899abe14552f4b61acda4dd1d7e Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Dec 2020 08:55:38 +0100 >Subject: [PATCH] Bug 27130: Don't display itemnumber under "File type" section > >There is no need to have the "File type" section when we attach a cover >item to an item (we cannot upload a zip file) > >This patch removes the legend of the fieldset. > >Test plan: >Attach a cover image to an item, then to a bibliographic record. >Notice the change and confirm it makes sense. > >Signed-off-by: Fridolin Somers <fridolin.somers@biblibre.com> >--- > .../prog/en/modules/tools/upload-images.tt | 28 +++++++++++-------- > 1 file changed, 17 insertions(+), 11 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt >index 592113b93c..1aa8f9def0 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/upload-images.tt >@@ -93,10 +93,10 @@ > <input type="hidden" name="runinbackground" id="runinbackground" value="" /> > <input type="hidden" name="completedJobID" id="completedJobID" value="" /> > </fieldset> >- <fieldset class="rows"> >- <legend>File type</legend> >- <ol> >- [% UNLESS itemnumber %] >+ [% UNLESS itemnumber %] >+ <fieldset class="rows"> >+ <legend>File type</legend> >+ <ol> > <li class="radio"> > [% IF (filetype != 'image' ) %] > <input type="radio" id="zipfile" name="filetype" value="zip" checked="checked" /> >@@ -122,13 +122,19 @@ > <label for="biblionumber">Enter cover biblionumber: </label> > <input type="text" id="biblionumber" name="biblionumber" value="[% biblionumber | html %]" size="15" /></span> > </li> >- [% ELSE %] >- <label for="itemnumber">Cover itemnumber: </label> >- <input type="text" id="itemnumber" name="itemnumber" value="[% itemnumber | html %]" size="15" readonly="readonly" /> >- <input type="hidden" name="filetype" value="image" /> >- [% END %] >- </ol> >- </fieldset> >+ </ol> >+ </fieldset> >+ [% ELSE %] >+ <fieldset class="rows"> >+ <ol> >+ <li> >+ <label for="itemnumber">Cover itemnumber: </label> >+ <input type="text" id="itemnumber" name="itemnumber" value="[% itemnumber | html %]" size="15" readonly="readonly" /> >+ <input type="hidden" name="filetype" value="image" /> >+ </li> >+ </ol> >+ </fieldset> >+ [% END %] > <fieldset class="rows"> > <legend>Options</legend> > <ol> >-- >2.29.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27130
:
114084
|
114102
|
114103
|
114104
|
114888
|
114889
|
114890
|
114917
|
115014