Attachment 114122 Details for Bug 12224 – Bug 12224: (follow-up) Move button to patron column in checkins table

[patch] Bug 12224: (follow-up) Move button to patron column in checkins table

Bug-12224-follow-up-Move-button-to-patron-column-i.patch (text/plain), 3.78 KB, created by Aleisha Amohia on 2020-12-02 22:31:47 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Aleisha Amohia

Created: 2020-12-02 22:31:47 UTC

Size: 3.78 KB

patch

obsolete

>From 6c6e0b6144a0e777a292de2fc485303cce9f0e30 Mon Sep 17 00:00:00 2001
>From: Owen Leonard <oleonard@myacpl.org>
>Date: Fri, 18 Sep 2020 13:53:29 +0000
>Subject: [PATCH] Bug 12224: (follow-up) Move button to patron column in
> checkins table
>
>This patch moves the "Print checkin slip" out of its own column and into
>the colum containing patron information. I think this makes more sense
>because the slip is specific to a patron, not the individual item which
>has been checked in.
>
>Also changed: printcheckinslip function should be triggered via a class,
>not a non-unique ID. The function should handle the click using
>"preventDefault" rather than "return false."
>
>To test, apply the patch and check in some items checked out to various
>patrons.
>
>- In the table of checked-in items, confirm that the "Print checkin
> slip" appears correctly in the column of patron information.
>- Confirm that the button works correctly to print the correct slip for
> the associated patron.
>
>Signed-off-by: David Nind <david@davidnind.com>
>
>Signed-off-by: Alexandra Speer <alexandra.speer@bsz-bw.de>
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt | 9 +++------
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>index 34a6866ec6..63d66443a3 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/returns.tt
>@@ -838,7 +838,6 @@
> <th class="ci-collection">Collection</th>
> <th class="ci-patron">Patron</th>
> <th class="ci-note">Note</th>
>- <th class="ci-printslip">&nbsp;</th>
> </tr>
> </thead>
> 
>@@ -909,6 +908,7 @@
> 
> 
> [% END %]
>+ <a class="btn btn-default btn-xs printcheckinslip" href="#" data-borrowernumber="[% riloo.patron.borrowernumber | html %]"> Print checkin slip</a>
> [% ELSE %]
> Not checked out
> [% END %]
>@@ -924,9 +924,6 @@
> [% riloo.itemnotes_nonpublic | html %]
> [% END %]
> </td>
>- <td class="ci-printslip actions">
>- <a id="printcheckinslip" href="#" class="btn btn-default" data-borrowernumber="[% riloo.patron.borrowernumber | html %]"> Print checkin slip</a>
>- </td>
> </tr>
> [% END # /FOREACH riloo %]
> </table> 
>@@ -1125,10 +1122,10 @@
> });
> $('[data-toggle="tooltip"]').tooltip();
> 
>- $("#printcheckinslip").click(function(){
>+ $(".printcheckinslip").on("click", function(e){
>+ e.preventDefault();
> var borrowernumber = $(this).data('borrowernumber');
> window.open("/cgi-bin/koha/members/printslip.pl?borrowernumber=" + borrowernumber + "&amp;print=checkinslip", "printwindow");
>- return false;
> });
> 
> });
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 12224: 28194 | 29693 | 41819 | 41820 | 44574 | 44576 | 44582 | 44584 | 91476 | 91477 | 91478 | 96970 | 96972 | 110308 | 110395 | 110396 | 110403 | 110404 | 110516 | 110529 | 110530 | 110531 | 110576 | 110577 | 110578 | 114121 | 114122 | 114123 | 114124 | 116135 | 116482 | 116485 | 116486 | 116487 | 116488 | 116489 | 117245 | 117246 | 117247 | 117248 | 117249 | 117250 | 117620 | 117812 | 117813 | 117814 | 117815 | 117816 | 117817 | 117818 | 117819