Bugzilla – Attachment 114141 Details for
Bug 27068
HoldsQueue doesn't know how to use holds groups
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27068: Fix errors in _checkHoldPolicy
Bug-27068-Fix-errors-in-checkHoldPolicy.patch (text/plain), 1.29 KB, created by
Kyle M Hall (khall)
on 2020-12-03 11:49:54 UTC
(
hide
)
Description:
Bug 27068: Fix errors in _checkHoldPolicy
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2020-12-03 11:49:54 UTC
Size:
1.29 KB
patch
obsolete
>From 7892b05c122673b741588967163248faed4ad366 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Thu, 3 Dec 2020 06:34:33 -0500 >Subject: [PATCH] Bug 27068: Fix errors in _checkHoldPolicy > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > C4/HoldsQueue.pm | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/C4/HoldsQueue.pm b/C4/HoldsQueue.pm >index 9429dfe54e..8c17467287 100644 >--- a/C4/HoldsQueue.pm >+++ b/C4/HoldsQueue.pm >@@ -383,8 +383,8 @@ sub _checkHoldPolicy { > my $hold_fulfillment_policy = $item->{hold_fulfillment_policy}; > > return 0 if $hold_fulfillment_policy eq 'holdgroup' && !$library->validate_hold_sibling({branchcode => $request->{branchcode}}); >- return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->$hold_fulfillment_policy; >- return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->$hold_fulfillment_policy; >+ return 0 if $hold_fulfillment_policy eq 'homebranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy}; >+ return 0 if $hold_fulfillment_policy eq 'holdingbranch' && $request->{branchcode} ne $item->{$hold_fulfillment_policy}; > > my $patronLibrary = Koha::Libraries->find($request->{borrowerbranch}); > >-- >2.24.1 (Apple Git-126)
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27068
:
113900
|
114125
|
114140
|
114141
|
114142
|
115987
|
116022
|
116023
|
116024
|
116025
|
116026
|
116607
|
116608
|
116609
|
116610
|
116814
|
116815
|
116816
|
116817
|
117215