Bugzilla – Attachment 114162 Details for
Bug 27127
Wrong display of messages if there was only 1 record modified
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27127: Make Koha::BackgroundJob->messages return a scalar
Bug-27127-Make-KohaBackgroundJob-messages-return-a.patch (text/plain), 1.15 KB, created by
Lucas Gass (lukeg)
on 2020-12-03 18:46:20 UTC
(
hide
)
Description:
Bug 27127: Make Koha::BackgroundJob->messages return a scalar
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2020-12-03 18:46:20 UTC
Size:
1.15 KB
patch
obsolete
>From bd5432e5dd9a58ee6496409c8993a016469dcc32 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 1 Dec 2020 15:35:11 +0100 >Subject: [PATCH] Bug 27127: Make Koha::BackgroundJob->messages return a scalar > >Otherwise the code in the template is not handled correctly: >112 [% FOR m IN job.messages %] > >m will become each key/val of the message hash: >{"type":"success","biblionumber":"1","code":"biblio_modified"} >And not the whole hash > >Test plan: >Modify one biblio using the batch record modification tool >Modify two biblios using the batch record modification tool >Go to the detail view of each job and confirm that with this patch the >display is correct > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > Koha/BackgroundJob.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm >index 0b1b36de50..d375dfa0d5 100644 >--- a/Koha/BackgroundJob.pm >+++ b/Koha/BackgroundJob.pm >@@ -167,7 +167,7 @@ sub messages { > @messages = @{ $data_dump->{messages} }; > } > >- return @messages; >+ return \@messages; > } > > =head3 report >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27127
:
114073
|
114162
|
114491