Attachment 114208 Details for Bug 15448 – Bug 15448: Filter out items hidden in OPAC on placing hold

[patch] Bug 15448: Filter out items hidden in OPAC on placing hold

Bug-15448-Filter-out-items-hidden-in-OPAC-on-placi.patch (text/plain), 2.63 KB, created by Kyle M Hall (khall) on 2020-12-04 18:27:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2020-12-04 18:27:19 UTC

Size: 2.63 KB

patch

obsolete

>From 0a886d6ec08b07cb2ae64d957ebfc8f1f5d40fd0 Mon Sep 17 00:00:00 2001
>From: Tomas Cohen Arazi <tomascohen@theke.io>
>Date: Fri, 4 Dec 2020 08:21:36 -0300
>Subject: [PATCH] Bug 15448: Filter out items hidden in OPAC on placing hold
>
>This patch leverages on bug 24254's
>Koha::Items->filter_by_visible_in_opac to filter out items that
>shouldn't be presented to the end user in the OPAC interface.
>
>To test:
>1. Circulation and Fine rules for item-level holds are set to allow.
>2. Setting the OpacHiddenItems preference to "ccode: [SUPPRESS]"
>3. An item with collection Code Suppress is set.
>4. Search for the title in the OPAC.
>=> SUCCESS: The Suppress ccode item isn't shown.
>5. View the detail page for the title.
>=> SUCCESS: The suppress ccode item isn't shown.
>6. Place a hold on the item:
>  -- Click "Show more options"
>  -- Select "A specific item"
>=> FAIL: the ccode with the opachiddenitems rule has an item that appear in the list to place a hold
>7. Apply this patch and repeat 6
>=> SUCCESS: The item doesn't show!
>8. Sign off :-D
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> opac/opac-reserve.pl | 12 ++++++++++++
> 1 file changed, 12 insertions(+)
>
>diff --git a/opac/opac-reserve.pl b/opac/opac-reserve.pl
>index b0ed088689..139d7101af 100755
>--- a/opac/opac-reserve.pl
>+++ b/opac/opac-reserve.pl
>@@ -71,6 +71,12 @@ for ( C4::Context->preference("OPACShowHoldQueueDetails") ) {
> }
> 
> my $patron = Koha::Patrons->find( $borrowernumber );
>+my $category = $patron->category;
>+# no OpacHiddenItems rules used if category is excepted
>+my $item_hide_rules =
>+    ( $category->override_hidden_items )
>+    ? {}
>+    : C4::Context->yaml_preference('OpacHiddenItems');
> 
> my $can_place_hold_if_available_at_pickup = C4::Context->preference('OPACHoldsIfAvailableAtPickup');
> unless ( $can_place_hold_if_available_at_pickup ) {
>@@ -461,6 +467,12 @@ foreach my $biblioNum (@biblionumbers) {
>     my @notforloan_avs = Koha::AuthorisedValues->search_by_koha_field({ kohafield => 'items.notforloan', frameworkcode => $frameworkcode });
>     my $notforloan_label_of = { map { $_->authorised_value => $_->opac_description } @notforloan_avs };
> 
>+    my $visible_items = { map { $_->itemnumber => 1 } $biblio->items->filter_by_visible_in_opac( { rules => $item_hide_rules } ) };
>+
>+    # Only keep the items that are visible in the opac (i.e. those in %visible_items)
>+    # FIXME: We should get rid of itemInfos altogether and use $visible_items
>+    $biblioData->{itemInfos} = [ grep { $visible_items->{ $_->{itemnumber} } } @{ $biblioData->{itemInfos} } ];
>+
>     $biblioLoopIter{itemLoop} = [];
>     my $numCopiesAvailable = 0;
>     my $numCopiesOPACAvailable = 0;
>-- 
>2.24.1 (Apple Git-126)

Actions: View | Diff | Splinter Review

Attachments on bug 15448: 46100 | 113875 | 113876 | 114188 | 114189 | 114191 | 114193 | 114194 | 114208 | 114209 | 114263 | 114264 | 114578 | 115133 | 115134