Attachment 114238 Details for Bug 27142 – Bug 27142: Don't interpolate batch_type variable

[patch] Bug 27142: Don't interpolate batch_type variable

Bug-27142-Dont-interpolate-batchtype-variable.patch (text/plain), 1.84 KB, created by Martin Renvoize (ashimema) on 2020-12-07 16:56:49 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Martin Renvoize (ashimema)

Created: 2020-12-07 16:56:49 UTC

Size: 1.84 KB

patch

obsolete

>From 6086b01632d90435e61285f0d561afc8dea35a4e Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Thu, 3 Dec 2020 13:30:34 +0000
>Subject: [PATCH] Bug 27142: Don't interpolate batch_type variable
>
>To test:
>1 - Create a report like:
>    SELECT * FROM borrowers LIMIT 50
>2 - Run the report
>3 - Attempt batch modification - it fails showing every row as an unfound cardnumber
>4 - Apply patch
>5 - Repeat
>6 - Success!
>7 - Edit report to:
>    SELECT * FROM biblio LIMIT 50
>8 - Repeat test
>9 - Ensure batch modification and deletion work
>
>Signed-off-by: David Nind <david@davidnind.com>
>Signed-off-by: Martin Renvoize <martin.renvoize@ptfs-europe.com>
>---
> .../prog/en/modules/reports/guided_reports_start.tt             | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 98716fd7bf..27859b9b5c 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -940,7 +940,7 @@
>                                     [%- FOREACH result IN results %]
>                                         [%- FOREACH cells IN result.cells %]
>                                             [%- place = loop.index %]
>-                                            [%- IF header_row.$place.cell == $batch_type || header_types.item(header_row.$place.cell) == $batch_type %]
>+                                            [%- IF header_row.$place.cell == batch_type || header_types.item(header_row.$place.cell) == batch_type %]
> [%# We must not add whitespace to the cardnumbers %][% cells.cell | html %]
>                                             [%- END %]
>                                         [%- END %]
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 27142: 114146 | 114167 | 114238