Attachment 114257 Details for Bug 27166 – Bug 27166: Unit tests

[patch] Bug 27166: Unit tests

Bug-27166-Unit-tests.patch (text/plain), 1.58 KB, created by Nick Clemens (kidclamp) on 2020-12-08 14:22:06 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-12-08 14:22:06 UTC

Size: 1.58 KB

patch

obsolete

>From 5fcb2dbe828eae419187c5c2e1253a60416f27b0 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 8 Dec 2020 14:18:11 +0000
>Subject: [PATCH] Bug 27166: Unit tests
>
>---
> t/db_dependent/SIP/Transaction.t | 9 ++++++++-
> 1 file changed, 8 insertions(+), 1 deletion(-)
>
>diff --git a/t/db_dependent/SIP/Transaction.t b/t/db_dependent/SIP/Transaction.t
>index c4c164adb1..d9cbf35490 100755
>--- a/t/db_dependent/SIP/Transaction.t
>+++ b/t/db_dependent/SIP/Transaction.t
>@@ -272,9 +272,10 @@ subtest do_hold => sub {
> };
> 
> subtest do_checkin => sub {
>-    plan tests => 8;
>+    plan tests => 11;
> 
>     my $library = $builder->build_object( { class => 'Koha::Libraries' } );
>+    my $library2 = $builder->build_object( { class => 'Koha::Libraries' } );
>     my $patron = $builder->build_object(
>         {
>             class => 'Koha::Patrons',
>@@ -320,6 +321,12 @@ subtest do_checkin => sub {
>     is( $patron->checkouts->count, 1, 'Checkout should have been done successfully');
>     $ci_transaction->do_checkin($library->branchcode, undef);
>     is( $patron->checkouts->count, 0, 'Checkin should have been done successfully');
>+
>+    my $result  = $ci_transaction->do_checkin($library2->branchcode, undef);
>+    is($ci_transaction->alert_type,'04',"Checkin of item no issued at another branch succeeds");
>+    is_deeply($result,{ messages => { 'NotIssued' => $item->barcode, 'WasTransfered' => 1 } },"Messages show not issued and transferred");
>+    is( $ci_transaction->item->destination_loc,$library->branchcode,"Item destination correctly set");
>+
> };
> 
> subtest checkin_lost => sub {
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27166: 114257 | 114258 | 114281 | 114282 | 114301 | 114302 | 114536