Attachment 114282 Details for Bug 27166 – Bug 27166: Set destination_loc to item->homebranch

[patch] Bug 27166: Set destination_loc to item->homebranch

Bug-27166-Set-destinationloc-to-item-homebranch.patch (text/plain), 1.64 KB, created by Victor Grousset/tuxayo on 2020-12-09 14:47:28 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Victor Grousset/tuxayo

Created: 2020-12-09 14:47:28 UTC

Size: 1.64 KB

patch

obsolete

>From eee7050ebac16a9c5e8052c5edcb0fb98eae027f Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Tue, 8 Dec 2020 14:18:35 +0000
>Subject: [PATCH] Bug 27166: Set destination_loc to item->homebranch
>
>In bug 21020 we used the issue to fetch the item and then the homebranch.
>This fails when the item is not issued. We fetch the item already, so we
>can use it directly
>
>To test:
>1 - Have an item belonging to branch A
>2 - Check it in via sip at branch B:
>    perl misc/sip_cli_emulator.pl -a localhost -p 6001 -su term1 -sp term1 --item CHESS1 -l FPL -m checkin
>3 - The read command is blank and there is a warn about uninitialized data
>4 - Apply patch
>5 - Restart sip server
>6 - Check the item in at branch A using the sip cli emulator
>7 - Check it in at branch B
>8 - This time the checkin should succeed and the output msg should be included
>
>Signed-off-by: Victor Grousset/tuxayo <victor@tuxayo.net>
>---
> C4/SIP/ILS/Transaction/Checkin.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/SIP/ILS/Transaction/Checkin.pm b/C4/SIP/ILS/Transaction/Checkin.pm
>index 274fda9325..1b82a7138b 100644
>--- a/C4/SIP/ILS/Transaction/Checkin.pm
>+++ b/C4/SIP/ILS/Transaction/Checkin.pm
>@@ -133,7 +133,7 @@ sub do_checkin {
>         $self->alert_type('04');            # send to other branch
>     }
>     if ($messages->{WasTransfered}) { # set into transit so tell unit
>-        $self->{item}->destination_loc($issue->item->homebranch);
>+        $self->{item}->destination_loc($item->homebranch);
>         $self->alert_type('04');            # send to other branch
>     }
>     if ($messages->{ResFound} || $checkin_blocked_by_holds ) {
>-- 
>2.29.2

Actions: View | Diff | Splinter Review

Attachments on bug 27166: 114257 | 114258 | 114281 | 114282 | 114301 | 114302 | 114536