Bugzilla – Attachment 114293 Details for
Bug 26953
Phone & SMS transports always displayed in overdue status triggers
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 26953: Hide phone and itiva from "Overdue notice/status triggers"
Bug-26953-Hide-phone-and-itiva-from-Overdue-notice.patch (text/plain), 3.07 KB, created by
Lucas Gass (lukeg)
on 2020-12-09 23:35:21 UTC
(
hide
)
Description:
Bug 26953: Hide phone and itiva from "Overdue notice/status triggers"
Filename:
MIME Type:
Creator:
Lucas Gass (lukeg)
Created:
2020-12-09 23:35:21 UTC
Size:
3.07 KB
patch
obsolete
>From dd2e8963ef708c55913860350a3012d62faf0a6b Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Dec 2020 10:52:27 +0100 >Subject: [PATCH] Bug 26953: Hide phone and itiva from "Overdue notice/status > triggers" > >If the prefs are off we should not display the checkboxes > >Test plan: >1. Turn off PhoneNotification and TalkingTechItivaPhoneNotification >2. Go to the "Overdue notice/status triggers" and confirm that phone and >itiva columns are not displayed >3. Turn the prefs on and confirm the checkboxes are now displayed > >Signed-off-by: Lucas Gass <lucas@bywatersolutions.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt | 8 ++++---- > 1 file changed, 4 insertions(+), 4 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >index 22d4050fe0..8fea31861b 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/tools/overduerules.tt >@@ -73,6 +73,8 @@ > <th scope="col">Letter</th> > <th scope="col">Restrict</th> > [% FOREACH mtt IN message_transport_types %] >+ [% NEXT IF mtt == 'itiva' AND !Koha.Preference('TalkingTechItivaPhoneNotification') %] >+ [% NEXT IF mtt == 'phone' AND !Koha.Preference('PhoneNotification') %] > <th scpre="col"> > [% SWITCH mtt %] > [% CASE 'email' %] >@@ -121,16 +123,14 @@ > [% END %] > </td> > [% FOREACH mtt IN value.message_transport_types %] >+ [% NEXT IF mtt.value == 'itiva' AND !Koha.Preference('TalkingTechItivaPhoneNotification') %] >+ [% NEXT IF mtt.value == 'phone' AND !Koha.Preference('PhoneNotification') %] > <td> > [% IF mtt.selected %] > <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" checked="checked" /> > [% ELSE %] > [% IF mtt.value == "sms" and not Koha.Preference("SMSSendDriver") %] > <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" /> >- [% ELSIF mtt.value == "itiva" and not Koha.Preference("TalkingTechItivaPhoneNotification") %] >- <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" /> >- [% ELSIF mtt.value == "phone" and not Koha.Preference("PhoneNotification") %] >- <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" disabled="disabled" /> > [% ELSE %] > <input type="checkbox" name="mtt[% tab.number | html %]-[% value.overduename | html %]" value="[% mtt.value | html %]" /> > [% END %] >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 26953
:
114089
|
114090
|
114293
|
114621