Attachment 114372 Details for Bug 26742 – Bug 26742: Remove die from connect

[patch] Bug 26742: Remove die from connect

Bug-26742-Remove-die-from-connect.patch (text/plain), 1.03 KB, created by Jonathan Druart on 2020-12-14 09:07:33 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2020-12-14 09:07:33 UTC

Size: 1.03 KB

patch

obsolete

>From 9cc5da30ca824a678509d7d22fd5dfc178d223cd Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 14 Dec 2020 10:05:02 +0100
>Subject: [PATCH] Bug 26742: Remove die from connect
>
>The change was not advertised and it needs to be done on a separate bug
>report (+ test coverage)
>---
> Koha/BackgroundJob.pm | 8 +-------
> 1 file changed, 1 insertion(+), 7 deletions(-)
>
>diff --git a/Koha/BackgroundJob.pm b/Koha/BackgroundJob.pm
>index 1e7871abdc..81ed83f765 100644
>--- a/Koha/BackgroundJob.pm
>+++ b/Koha/BackgroundJob.pm
>@@ -77,13 +77,7 @@ sub connect {
>         $credentials->{host} = $config->{vhost} if $config->{vhost};
>     }
>     my $stomp = Net::Stomp->new( { hostname => $hostname, port => $port } );
>-    my $frame = $stomp->connect( $credentials );
>-    unless ($frame && $frame->command eq 'CONNECTED'){
>-        if ($frame){
>-            warn $frame->as_string;
>-        }
>-        die "Cannot connect to message broker";
>-    }
>+    $stomp->connect( $credentials );
>     return $stomp;
> }
> 
>-- 
>2.20.1

Actions: View | Diff | Splinter Review

Attachments on bug 26742: 112013 | 112015 | 113906 | 114288 | 114372 | 117533 | 117534