Bugzilla – Attachment 114407 Details for
Bug 27239
FRBRizeEditions is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27239: Detail templates remove redundant tests
Bug-27239-Detail-templates-remove-redundant-test.patch (text/plain), 4.17 KB, created by
Didier Gautheron
on 2020-12-15 11:10:46 UTC
(
hide
)
Description:
Bug 27239: Detail templates remove redundant tests
Filename:
MIME Type:
Creator:
Didier Gautheron
Created:
2020-12-15 11:10:46 UTC
Size:
4.17 KB
patch
obsolete
>From d98bfdbf3b14420657e4c71a1269ff46158a01db Mon Sep 17 00:00:00 2001 >From: Didier Gautheron <didier.gautheron@biblibre.com> >Date: Tue, 15 Dec 2020 12:04:40 +0100 >Subject: [PATCH] Bug 27239: Detail templates remove redundant test > >Template variables FRBRizeEditions and OPACFRBRizeEditions aren't assigned with >syspref values and are redundant anyway. If syspref FRBRizeEditions or >OPACFRBRizeEditions aren't set XISBN is empty. > >Test plan: >1 - Set Sysprefs ThingISBN, FRBRizeEditions and OPACFRBRizeEditions >2 - Search for a notice with multiple ISBN in ThingISBN and with some of these >ISBNs in Koha. >Example: >http://www.librarything.com/api/thingISBN/0452254264 >In koha imported from LOC ISBN: >0452254264 >0198185219 >3 - Select one notice >4 - Edition tab is not there. >5 - Apply patch >6 - Redo 2 >7 - Edition tab is there. >8 - Unset FRBRizeEditions and OPACFRBRizeEditions >9 - Edition tab isn't there. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt | 6 +++--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt | 6 +++--- > 2 files changed, 6 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >index fc6745156f..0540956192 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt >@@ -245,7 +245,7 @@ > [% IF ( subscriptionsnumber ) %]<li><a href="#subscriptions">Subscriptions</a></li>[% END %] > [% IF Koha.Preference('AcquisitionDetails') %]<li><a href="#acq_details">Acquisition details</a></li>[% END %] > [% IF suggestions.count %]<li><a href="#suggestion_details">Suggestion details</a></li>[% END %] >-[% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %][% END %] >+[% IF ( XISBNS ) %]<li><a href="#editions">Editions</a></li>[% END %] > [% IF ( LocalCoverImages ) %] > [% IF ( localimages.count || CAN_user_tools_upload_local_cover_images ) %] > <li> >@@ -863,7 +863,7 @@ Note that permanent location is a code, and location may be an authval. > </div> > [% END %] > >-[% IF ( FRBRizeEditions ) %][% IF ( XISBNS ) %] >+[% IF ( XISBNS ) %] > <div id="editions"><h4>Editions</h4> > <table> > [% FOREACH XISBN IN XISBNS %]<tr>[% IF ( AmazonCoverImages ) %]<td><a href="http://www.amazon.com/gp/reader/[% XISBN.normalized_isbn | uri %][% AmazonAssocTag | uri %]#reader-link"><img src="https://images-na.ssl-images-amazon.com/images/P/[% XISBN.normalized_isbn | html %].01._AA75_PU_PU-5_.jpg" /></a></td>[% END %] >@@ -877,7 +877,7 @@ Note that permanent location is a code, and location may be an authval. > </td> > > [% END %] >-</table></div>[% END %] >+</table></div> > [% END %] > > [% IF ( LocalCoverImages ) %] >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >index 4e0d27de9e..785bd18d65 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt >@@ -568,7 +568,7 @@ > [% END %] > [% END %] > >- [% IF ( OPACFRBRizeEditions && XISBNS ) %] >+ [% IF XISBNS %] > <li id="tab_editions"><a href="#editions">Editions</a></li> > [% END %] > >@@ -953,7 +953,7 @@ > </div> <!-- / #comments --> > [% END # / IF reviewson %] > >- [% IF ( OPACFRBRizeEditions && XISBNS ) %] >+ [% IF XISBNS %] > <div id="editions"> > <h4>Other editions of this work</h4> > <table class="table table-bordered table-striped"> >@@ -992,7 +992,7 @@ > [% END # / FOREACH XISBNS %] > </table> > </div> <!-- / #editions --> >- [% END # / IF OPACFRBRizeEditions && XISBNS %] >+ [% END # / IF XISBNS %] > > [% IF ( HTML5MediaEnabled ) %] > <div id="html5media"> >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27239
:
114407
|
119618
|
119806