Attachment 114467 Details for Bug 27247 – Bug 27247: Re-add highlighting to the quote editor

[patch] Bug 27247: Re-add highlighting to the quote editor

Bug-27247-Re-add-highlighting-to-the-quote-editor.patch (text/plain), 1.61 KB, created by Lucas Gass (lukeg) on 2020-12-17 00:04:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Lucas Gass (lukeg)

Created: 2020-12-17 00:04:02 UTC

Size: 1.61 KB

patch

obsolete

>From b1406193fe260b692ab54363a93fa03dd3ca12e9 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 16 Dec 2020 11:32:20 +0100
>Subject: [PATCH] Bug 27247: Re-add highlighting to the quote editor
>
>Caused by
>  commmit 247dca306407ac9568344a0a37aca3bbcffc2468
>  Bug 23013: Upgrade DataTables in the staff client
>
>which removed
>
>-tr.even.selected td {
>-    background-color: #D3D3D3;
>-}
>
>There was no more highlighting when trying to delete an imported quote, as there was before
>(see screenshot from the manual https://gitlab.com/koha-community/koha-manual/-/blob/master/source/images/tools/qotd/selectfordelete.png)
>
>It was, however, possible to delete imported quotes, you just don't see which ones you are deleting.
>
>Test plan:
>1) Create a CSV with two columns first the name, then the quote (I've attached a CSV that I've done for testing purposes)
>2) Go to Tools > Edit quotes for the QOTD feature
>3) Click 'Import quotes'
>4) Click 'Browse' and choose the CSV created earlier
>5) Click on the id of a couple of quotes. Notice those lintes are highlighted
>
>Signed-off-by: Lucas Gass <lucas@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/css/quotes.css | 5 +++++
> 1 file changed, 5 insertions(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/css/quotes.css b/koha-tmpl/intranet-tmpl/prog/css/quotes.css
>index 3344b65340..50914f6489 100644
>--- a/koha-tmpl/intranet-tmpl/prog/css/quotes.css
>+++ b/koha-tmpl/intranet-tmpl/prog/css/quotes.css
>@@ -36,3 +36,8 @@
> #quotes_editor {
>     width       : 100%;
> }
>+
>+tr.odd.selected td,
>+tr.even.selected td {
>+    background-color: #D3D3D3;
>+}
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 27247: 114432 | 114467 | 114570