Attachment 114475 Details for Bug 17364 – Bug 17364: (follow-up) Do not check excluded fields

[patch] Bug 17364: (follow-up) Do not check excluded fields

Bug-17364-follow-up-Do-not-check-excluded-fields.patch (text/plain), 1.25 KB, created by Nick Clemens (kidclamp) on 2020-12-17 11:26:50 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2020-12-17 11:26:50 UTC

Size: 1.25 KB

patch

obsolete

>From 552ca32e233dbdb5a0f631b783aa1408361c635d Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Thu, 17 Dec 2020 09:05:25 +0100
>Subject: [PATCH] Bug 17364: (follow-up) Do not check excluded fields
>
>When clicking on "Select all" excluded fields are selected.
>Even if they are not saved into preference, this is disturbing.
>
>Test plan :
>1) Edit BorroweUnwantedFields system preference
>2) Click "Select all"
>3) See that branchcode is not selected
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
>index b4d243cb2c..c25854b619 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/pages/preferences.js
>@@ -280,7 +280,7 @@ $( document ).ready( function () {
> 
>     $("#select_all").on("click",function(e){
>         e.preventDefault();
>-        $(".dbcolumn_selection").prop("checked", true);
>+        $(".dbcolumn_selection:not(:disabled)").prop("checked", true);
>     });
>     $("#clear_all").on("click",function(e){
>         e.preventDefault();
>-- 
>2.11.0

Actions: View | Diff | Splinter Review

Attachments on bug 17364: 113238 | 113239 | 114409 | 114470 | 114471 | 114472 | 114473 | 114475 | 116114 | 116115 | 116116