Bugzilla – Attachment 114565 Details for
Bug 27148
Internal Server Error during self registration 20.11
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 27148: (QA follow-up) Calculate default_strong_password correctly
Bug-27148-QA-follow-up-Calculate-defaultstrongpass.patch (text/plain), 2.37 KB, created by
Nick Clemens (kidclamp)
on 2020-12-21 16:11:26 UTC
(
hide
)
Description:
Bug 27148: (QA follow-up) Calculate default_strong_password correctly
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2020-12-21 16:11:26 UTC
Size:
2.37 KB
patch
obsolete
>From 041b06ba5e0241486636b6304334026db805025d Mon Sep 17 00:00:00 2001 >From: Nick Clemens <nick@bywatersolutions.com> >Date: Mon, 21 Dec 2020 16:06:35 +0000 >Subject: [PATCH] Bug 27148: (QA follow-up) Calculate default_strong_password > correctly > >Fix a typo lenght for length > >If category strong password is not set, then we fall back to the preference, but that can be "" - which should be treated as 0 >--- > koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 6 +++--- > 1 file changed, 3 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >index e7212c4225..d9ee294706 100644 >--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt >@@ -1235,12 +1235,12 @@ > var PWD_STRONG_MSG = _("Password must contain at least %s characters, including UPPERCASE, lowercase and numbers"); > var PWD_WEAK_MSG = _("Password must contain at least %s characters"); > var default_password_length = [% defaultCategory.effective_min_password_length | html %]; >- var default_strong_password = [% defaultCategory.effective_require_strong_password | html %]; >+ var default_strong_password = [% defaultCategory.effective_require_strong_password ? defaultCategory.effective_require_strong_password : 0 | html %]; > $(document).ready(function() { > var setPwdMessage = function() { > var require_strong = $('select#borrower_categorycode option:selected').length ? $('select#borrower_categorycode option:selected').data('pwdStrong') : default_strong_password; >- var min_lenght = $('select#borrower_categorycode option:selected').length ? $('select#borrower_categorycode option:selected').data('pwdLength') : default_password_length; >- $('#password_alert').html((require_strong?PWD_STRONG_MSG:PWD_WEAK_MSG).format(min_lenght)); >+ var min_length = $('select#borrower_categorycode option:selected').length ? $('select#borrower_categorycode option:selected').data('pwdLength') : default_password_length; >+ $('#password_alert').html((require_strong?PWD_STRONG_MSG:PWD_WEAK_MSG).format(min_length)); > }; > setPwdMessage(); > $('select#borrower_categorycode').change(setPwdMessage); >-- >2.11.0
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 27148
:
114154
|
114161
|
114235
|
114290
|
114563
|
114564
| 114565